Source/core/animation/DocumentTimelineTest.cpp - Issue 176903004: Have Document::timeline() / Document::transitionTimeline() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DocumentTimelineTest.cpp

Issue 176903004: Have Document::timeline() / Document::transitionTimeline() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/DocumentTimelineTest.cpp

diff --git a/Source/core/animation/DocumentTimelineTest.cpp b/Source/core/animation/DocumentTimelineTest.cpp

index 8eefabc7118026d0f937d0ae4983a652b85cac7a..0b3af5910916a5b7f4a29579ee8f9792d368b708 100644

--- a/Source/core/animation/DocumentTimelineTest.cpp

+++ b/Source/core/animation/DocumentTimelineTest.cpp

@@ -275,7 +275,7 @@ TEST_F(AnimationDocumentTimelineTest, PlayAfterDocumentDeref)

timing.iterationDuration = 2;

timing.startDelay = 5;

- timeline = document->timeline();

+ timeline = &document->timeline();

element = nullptr;

document = nullptr;

« no previous file with comments | « Source/core/animation/DocumentAnimations.cpp ('k') | Source/core/animation/ElementAnimation.cpp » ('j') | no next file with comments »