Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1768953002: Remove WebFormElement::wasUserSubmitted. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebFormElement::wasUserSubmitted. As autofill is no longer using this (as of r339061), drop this this public API. R= BUG= Committed: https://crrev.com/f4401f2b87e304b1ec38b5e76e9449e20efb3ed0 Cr-Commit-Position: refs/heads/master@{#379683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 5 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebFormElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Assuming this API won't see other uses, seems preferable to remove.
4 years, 9 months ago (2016-03-07 09:59:12 UTC) #2
tkent
lgtm
4 years, 9 months ago (2016-03-07 22:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768953002/1
4 years, 9 months ago (2016-03-07 23:00:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 23:41:04 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 23:42:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4401f2b87e304b1ec38b5e76e9449e20efb3ed0
Cr-Commit-Position: refs/heads/master@{#379683}

Powered by Google App Engine
This is Rietveld 408576698