Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 1768953002: Remove WebFormElement::wasUserSubmitted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
index 001143f978f03eb6431ed56afae46f5464e279cc..fcb3f89ecac62397f439fc48fdd6f3cf12ad7b87 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
@@ -72,7 +72,6 @@ HTMLFormElement::HTMLFormElement(Document& document)
, m_hasElementsAssociatedByParser(false)
, m_hasElementsAssociatedByFormAttribute(false)
, m_didFinishParsingChildren(false)
- , m_wasUserSubmitted(false)
, m_isSubmittingOrInUserJSSubmitEvent(false)
, m_shouldSubmit(false)
, m_isInResetFunction(false)
@@ -332,12 +331,12 @@ void HTMLFormElement::prepareForSubmission(Event* event)
m_isSubmittingOrInUserJSSubmitEvent = false;
if (m_shouldSubmit)
- submit(event, true, true);
+ submit(event, true);
}
void HTMLFormElement::submitFromJavaScript()
{
- submit(0, false, UserGestureIndicator::processingUserGesture());
+ submit(0, false);
}
void HTMLFormElement::submitDialog(PassRefPtrWillBeRawPtr<FormSubmission> formSubmission)
@@ -350,7 +349,7 @@ void HTMLFormElement::submitDialog(PassRefPtrWillBeRawPtr<FormSubmission> formSu
}
}
-void HTMLFormElement::submit(Event* event, bool activateSubmitButton, bool processingUserGesture)
+void HTMLFormElement::submit(Event* event, bool activateSubmitButton)
{
FrameView* view = document().view();
LocalFrame* frame = document().frame();
@@ -363,7 +362,6 @@ void HTMLFormElement::submit(Event* event, bool activateSubmitButton, bool proce
}
m_isSubmittingOrInUserJSSubmitEvent = true;
- m_wasUserSubmitted = processingUserGesture;
RefPtrWillBeRawPtr<HTMLFormControlElement> firstSuccessfulSubmitButton = nullptr;
bool needButtonActivation = activateSubmitButton; // do we need to activate a submit button?
@@ -668,11 +666,6 @@ void HTMLFormElement::setMethod(const AtomicString& value)
setAttribute(methodAttr, value);
}
-bool HTMLFormElement::wasUserSubmitted() const
-{
- return m_wasUserSubmitted;
-}
-
HTMLFormControlElement* HTMLFormElement::findDefaultButton() const
{
for (const auto& element : associatedElements()) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormElement.h ('k') | third_party/WebKit/Source/web/WebFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698