Dynamic updation of checked and selected attributes should reflect correct :default status

Invalidate pseudo default state when checked and selected attributes are updated dynamically.

Added tests to check if :default selector is reflected correctly in following cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226
Committed: https://crrev.com/60169b204c832cf0f3ac5b1387b6532fe2238b1a
Cr-Commit-Position: refs/heads/master@{#379743}

[ramya.v, 2016-03-07 05:07:54]

ramya.v@samsung.com changed reviewers:
+ tkent@chromium.org

[ramya.v, 2016-03-07 05:07:55]

Hi tkent, 

PTAL!
Please let me know if I have to check/handle any other dynamic conditions.

Thanks

[tkent, 2016-03-07 05:22:34]

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html
(right):

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:128: },
'Adding a checkbox with checked attribute dynamically to a DOM tree should
reflect the default checkbox.');
Plese remove this test.
This test isn't helpful because the checkbox doesn't have computed style before
it is added to a DOM tree.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:139: },
'Adding a radio element with checked attribute dynamically to a DOM tree should
reflect the default radio element.');
Ditto.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:162: },
'Adding an option element dynamically to a DOM tree should reflect default
option element.');
Ditto.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:164:
</script>
Please add the following tests:

* A radio/checkbox is in a document tree.
  It has no :default style.
  Click it by eventSender.
  It still has no :default style.
  setAttribute('checked', 'checked');
  It should have :default style.

* An OPTION element is in a document tree.
  It has no :default style.
  option.selected = true;
  It still has no :default style.
  option.setAttribute('selected', 'selected');
  It should have :default style.

[ramya.v, 2016-03-07 09:24:18]

Description was changed from

==========
Adding tests to check dynamic changes to option, checkbox and radio reflect
:default status

Tests added to check if :default selector is reflected correctly
in following cases.
a)Updating type attribute of input element.
b)Updating checked attribute of input element.
c)Updating selected attribute of option element.
d)Adding checkbox, radio, option elements dynamically to DOM.

BUG=591226
==========

to

==========
Invalidate pseudo default state when checked and selected attributes are updated
dynamically.

Added tests to check if :default selector is reflected correctly in following
cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226
==========

[ramya.v, 2016-03-07 10:03:02]

Updated as per review comments.
PTAL!

Thanks

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html
(right):

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:128: },
'Adding a checkbox with checked attribute dynamically to a DOM tree should
reflect the default checkbox.');
On 2016/03/07 05:22:34, tkent wrote:
> Plese remove this test.
> This test isn't helpful because the checkbox doesn't have computed style
before
> it is added to a DOM tree.

Done.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:139: },
'Adding a radio element with checked attribute dynamically to a DOM tree should
reflect the default radio element.');
On 2016/03/07 05:22:33, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:162: },
'Adding an option element dynamically to a DOM tree should reflect default
option element.');
On 2016/03/07 05:22:33, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1768913002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html:164:
</script>
On 2016/03/07 05:22:34, tkent wrote:
> Please add the following tests:
> 
> * A radio/checkbox is in a document tree.
>   It has no :default style.
>   Click it by eventSender.
>   It still has no :default style.
>   setAttribute('checked', 'checked');
>   It should have :default style.
> 
> * An OPTION element is in a document tree.
>   It has no :default style.
>   option.selected = true;
>   It still has no :default style.
>   option.setAttribute('selected', 'selected');
>   It should have :default style.

Done.

[tkent, 2016-03-07 15:23:50]

lgtm

https://codereview.chromium.org/1768913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/1768913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLInputElement.cpp:725: if
(m_inputType->isCheckable())
Please remove this |if|.  We may call pseudoStateChanged unconditionally because
it's not a heavy operation and we don't want to introduce input type checking to
HTMLInputElement.

[ramya.v, 2016-03-08 03:22:06]

https://codereview.chromium.org/1768913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/1768913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLInputElement.cpp:725: if
(m_inputType->isCheckable())
On 2016/03/07 15:23:50, tkent wrote:
> Please remove this |if|.  We may call pseudoStateChanged unconditionally
because
> it's not a heavy operation and we don't want to introduce input type checking
to
> HTMLInputElement.

Done.

[ramya.v, 2016-03-08 03:22:41]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2016-03-08 03:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1768913002/#ps40001
(title: "Updated as per review comments")

[commit-bot: I haz the power, 2016-03-08 03:23:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768913002/40001

[commit-bot: I haz the power, 2016-03-08 04:46:14]

Description was changed from

==========
Invalidate pseudo default state when checked and selected attributes are updated
dynamically.

Added tests to check if :default selector is reflected correctly in following
cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226
==========

to

==========
Invalidate pseudo default state when checked and selected attributes are updated
dynamically.

Added tests to check if :default selector is reflected correctly in following
cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226
==========

[commit-bot: I haz the power, 2016-03-08 04:46:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 04:47:32]

Description was changed from

==========
Invalidate pseudo default state when checked and selected attributes are updated
dynamically.

Added tests to check if :default selector is reflected correctly in following
cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226
==========

to

==========
Invalidate pseudo default state when checked and selected attributes are updated
dynamically.

Added tests to check if :default selector is reflected correctly in following
cases.
a)Updating type attribute of input element.
b)Updating checked status of input element.
c)Updating checked attribute of input element.
d)Updating selected status of option element.
e)Updating selected attribute of option element.

BUG=591226

Committed: https://crrev.com/60169b204c832cf0f3ac5b1387b6532fe2238b1a
Cr-Commit-Position: refs/heads/master@{#379743}
==========

[commit-bot: I haz the power, 2016-03-08 04:47:33]

Patchset 3 (id:??) landed as
https://crrev.com/60169b204c832cf0f3ac5b1387b6532fe2238b1a
Cr-Commit-Position: refs/heads/master@{#379743}