Issue 176863002: Fix null pointer dereference in CompositeEditCommand::moveParagraphs().

Issue 176863002: Fix null pointer dereference in CompositeEditCommand::moveParagraphs(). (Closed)

Created:
6 years, 10 months ago by Yuta Kitamura

Modified:
6 years, 10 months ago

Reviewers:
yoichio, tkent, yosin_UTC9

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix null pointer dereference in CompositeEditCommand::moveParagraphs(). Document::documentElement() may return null, and in that case we should not hand it to PlainTextRange::createRangeForSelection(). BUG=338542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167684

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename test. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -10 lines)			Patch
A	LayoutTests/editing/execCommand/resources/window-open-insert-list-crash-iframe.html	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/editing/execCommand/window-open-insert-list-crash.html	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A +	LayoutTests/editing/execCommand/window-open-insert-list-crash-expected.txt	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View		1 chunk	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

LGTM How about using iframe.contentWindow and iframe.contentDocument for avoiding loading another file?

6 years, 10 months ago (2014-02-24 03:36:36 UTC) #2

tkent

lgtm https://codereview.chromium.org/176863002/diff/1/LayoutTests/editing/execCommand/crash-issue-338542.html File LayoutTests/editing/execCommand/crash-issue-338542.html (right): https://codereview.chromium.org/176863002/diff/1/LayoutTests/editing/execCommand/crash-issue-338542.html#newcode1 LayoutTests/editing/execCommand/crash-issue-338542.html:1: <!DOCTYPE html> The name 'crash-issue-338542' isn't helpful. 'window-open-insert-li-crash' ...

6 years, 10 months ago (2014-02-24 03:39:37 UTC) #3

Yuta Kitamura

https://codereview.chromium.org/176863002/diff/1/LayoutTests/editing/execCommand/crash-issue-338542.html File LayoutTests/editing/execCommand/crash-issue-338542.html (right): https://codereview.chromium.org/176863002/diff/1/LayoutTests/editing/execCommand/crash-issue-338542.html#newcode1 LayoutTests/editing/execCommand/crash-issue-338542.html:1: <!DOCTYPE html> On 2014/02/24 03:39:37, tkent wrote: > The ...

6 years, 10 months ago (2014-02-24 06:00:42 UTC) #4

Yuta Kitamura

On 2014/02/24 03:36:36, Yoshi wrote: > LGTM > > How about using iframe.contentWindow and iframe.contentDocument ...

6 years, 10 months ago (2014-02-24 06:09:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/176863002/80001

6 years, 10 months ago (2014-02-24 06:10:31 UTC) #7

Message was sent while issue was closed.

Change committed as 167684

Expand Messages | Collapse Messages