LayoutTests/editing/execCommand/crash-issue-338542.html - Issue 176863002: Fix null pointer dereference in CompositeEditCommand::moveParagraphs().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/crash-issue-338542.html

Issue 176863002: Fix null pointer dereference in CompositeEditCommand::moveParagraphs(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	tkent 2014/02/24 03:39:37 The name 'crash-issue-338542' isn't helpful. 'win The name 'crash-issue-338542' isn't helpful. 'window-open-insert-li-crash' or something? Yuta Kitamura 2014/02/24 06:00:42 To tell the truth I didn't think of a good name; t Show quoted text On 2014/02/24 03:39:37, tkent wrote: > The name 'crash-issue-338542' isn't helpful. 'window-open-insert-li-crash' or > something? To tell the truth I didn't think of a good name; the crash is super magical, since, for example, removing class="class2" from the body element magically eliminated the crash, so I was not sure if InsertOrderedList or window.open were playing a significant role here. But I agree with you and at least your name looks better than mine. Fixed in Patch Set 2.
	2 <html>

	3 <head>

	4 <title>Crash issue 338542</title>

	5 <script src="../../resources/js-test.js"></script>

	6 </head>

	7 <body>

	8 <script>

	9 description('Should not crash if we load a test case from crbug.com/338542.');

	10

	11 window.jsTestIsAsync = true;

	12

	13 window.addEventListener('message', didReceiveMessage, false);

	14

	15 var iframe = document.createElement('iframe');

	16 iframe.src = 'resources/crash-issue-338542-iframe.html';

	17 document.body.appendChild(iframe);

	18

	19 function didReceiveMessage(event)

	20 {

	21 shouldBeEqualToString('event.data', 'FINISH');

	22 document.body.removeChild(iframe);

	23 testPassed('Did not crash.');

	24 window.finishJSTest();

	25 }

	26 </script>

	27 </body>

	28 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/crash-issue-338542-expected.txt » ('j') | no next file with comments »