[Extension UI Views] Add tests for clicking the different message bubble buttons

[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)

Committed: https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727
Cr-Commit-Position: refs/heads/master@{#379627}

[Devlin, 2016-03-04 19:09:46]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-04 19:09:47]

As promised. :)

[asargent_no_longer_on_chrome, 2016-03-04 22:16:04]

nice, lgtm

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
File
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:70:
void ClickMessageBubbleDismissButton(ExtensionMessageBubbleView* bubble) {
consider shortening name to just "ClickDismiss()" as the "MessageBubbale"-ness
can be inferred from the argument type

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:75:
void ClickMessageBubbleActionButton(ExtensionMessageBubbleView* bubble) {
same thing here

[Devlin, 2016-03-05 00:36:27]

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
File
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:70:
void ClickMessageBubbleDismissButton(ExtensionMessageBubbleView* bubble) {
On 2016/03/04 22:16:03, Antony Sargent wrote:
> consider shortening name to just "ClickDismiss()" as the "MessageBubbale"-ness
> can be inferred from the argument type

Done (% ClickDismissButton rather than ClickDismiss, since "ClickAction" sounds
weird).

https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:75:
void ClickMessageBubbleActionButton(ExtensionMessageBubbleView* bubble) {
On 2016/03/04 22:16:03, Antony Sargent wrote:
> same thing here

Done.

[Devlin, 2016-03-05 00:36:41]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2016-03-05 00:36:42]

+Finnur for OWNERS

[Finnur, 2016-03-07 11:11:47]

LGTM

[Devlin, 2016-03-07 19:28:00]

Description was changed from

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
==========

to

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)
==========

[Devlin, 2016-03-07 19:28:43]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-07 19:28:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1768623002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-07 19:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768623002/20001

[commit-bot: I haz the power, 2016-03-07 20:16:56]

Description was changed from

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)
==========

to

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)
==========

[commit-bot: I haz the power, 2016-03-07 20:17:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 20:21:14]

Description was changed from

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)
==========

to

==========
[Extension UI Views] Add tests for clicking the different message bubble buttons

Add browser tests for clicking on the bubble's dismiss and action buttons, as
well as for focus loss. Regression tests for bug 590028.

BUG=591572
TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur)

Committed: https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727
Cr-Commit-Position: refs/heads/master@{#379627}
==========

[commit-bot: I haz the power, 2016-03-07 20:21:15]

Patchset 2 (id:??) landed as
https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727
Cr-Commit-Position: refs/heads/master@{#379627}

[Will Harris, 2016-03-12 02:06:54]

On 2016/03/07 20:21:15, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727
> Cr-Commit-Position: refs/heads/master@{#379627}

this cl is causing failures on the win10 bot see crbug.com/594317

I will revert shortly

[Will Harris, 2016-03-12 02:15:38]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1786933002/ by wfh@chromium.org.

The reason for reverting is: this is breaking the win10 fyi bot

see bug 594317.