Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1768623002: [Extension UI Views] Add tests for clicking the different message bubble buttons (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension UI Views] Add tests for clicking the different message bubble buttons Add browser tests for clicking on the bubble's dismiss and action buttons, as well as for focus loss. Regression tests for bug 590028. BUG=591572 TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur) Committed: https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727 Cr-Commit-Position: refs/heads/master@{#379627}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -6 lines) Patch
M chrome/browser/ui/extensions/extension_message_bubble_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc View 1 4 chunks +139 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Devlin
As promised. :)
4 years, 9 months ago (2016-03-04 19:09:47 UTC) #2
asargent_no_longer_on_chrome
nice, lgtm https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc File chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc (right): https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc#newcode70 chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:70: void ClickMessageBubbleDismissButton(ExtensionMessageBubbleView* bubble) { consider shortening name ...
4 years, 9 months ago (2016-03-04 22:16:04 UTC) #3
Devlin
https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc File chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc (right): https://codereview.chromium.org/1768623002/diff/1/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc#newcode70 chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc:70: void ClickMessageBubbleDismissButton(ExtensionMessageBubbleView* bubble) { On 2016/03/04 22:16:03, Antony Sargent ...
4 years, 9 months ago (2016-03-05 00:36:27 UTC) #4
Devlin
+Finnur for OWNERS
4 years, 9 months ago (2016-03-05 00:36:42 UTC) #6
Finnur
LGTM
4 years, 9 months ago (2016-03-07 11:11:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768623002/20001
4 years, 9 months ago (2016-03-07 19:29:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 20:17:00 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727 Cr-Commit-Position: refs/heads/master@{#379627}
4 years, 9 months ago (2016-03-07 20:21:15 UTC) #15
Will Harris
On 2016/03/07 20:21:15, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 9 months ago (2016-03-12 02:06:54 UTC) #16
Will Harris
4 years, 9 months ago (2016-03-12 02:15:38 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1786933002/ by wfh@chromium.org.

The reason for reverting is: this is breaking the win10 fyi bot

see bug 594317.

Powered by Google App Engine
This is Rietveld 408576698