Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 1768623002: [Extension UI Views] Add tests for clicking the different message bubble buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/settings_api_bubble_helper_views.cc
diff --git a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
index be6ff12e14ae20f836675c02b911ab77a4c13c11..ad5acdc68a81bc56edadf03b5363d72e3c8bb24d 100644
--- a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
+++ b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/settings_api_bubble_delegate.h"
#include "chrome/browser/extensions/settings_api_helpers.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/extensions/extension_message_bubble_factory.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -46,7 +47,8 @@ void ShowSettingsApiBubble(SettingsApiOverrideType type,
void MaybeShowExtensionControlledHomeNotification(Browser* browser) {
#if !defined(OS_WIN)
- return;
+ if (!ExtensionMessageBubbleFactory::is_enabled_for_testing())
+ return;
#endif
// The bubble will try to anchor itself against the home button
@@ -63,7 +65,8 @@ void MaybeShowExtensionControlledSearchNotification(
content::WebContents* web_contents,
AutocompleteMatch::Type match_type) {
#if !defined(OS_WIN)
- return;
+ if (!ExtensionMessageBubbleFactory::is_enabled_for_testing())
+ return;
#endif
if (AutocompleteMatch::IsSearchType(match_type) &&
@@ -80,7 +83,8 @@ void MaybeShowExtensionControlledSearchNotification(
void MaybeShowExtensionControlledNewTabPage(
Browser* browser, content::WebContents* web_contents) {
#if !defined(OS_WIN)
- return;
+ if (!ExtensionMessageBubbleFactory::is_enabled_for_testing())
+ return;
#endif
content::NavigationEntry* entry =
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698