Chromium Code Reviews| Index: Source/core/dom/DOMError.h |
| diff --git a/Source/core/dom/DOMError.h b/Source/core/dom/DOMError.h |
| index a66d0e2175f686d62a065babec403e35445fd363..bd442edcf78d8dc3e2acc3196d730ed3bc50cdf2 100644 |
| --- a/Source/core/dom/DOMError.h |
| +++ b/Source/core/dom/DOMError.h |
| @@ -29,36 +29,39 @@ |
| #include "bindings/v8/ScriptWrappable.h" |
| #include "core/dom/DOMException.h" |
| #include "core/dom/ExceptionCode.h" |
| +#include "heap/Handle.h" |
| #include "wtf/PassRefPtr.h" |
| #include "wtf/RefCounted.h" |
| #include "wtf/text/WTFString.h" |
| namespace WebCore { |
| -class DOMError : public RefCounted<DOMError>, public ScriptWrappable { |
| +class DOMError : public RefCountedWillBeGarbageCollectedFinalized<DOMError>, public ScriptWrappable { |
| public: |
| - static PassRefPtr<DOMError> create(const String& name) |
| + static PassRefPtrWillBeRawPtr<DOMError> create(const String& name) |
| { |
| - return adoptRef(new DOMError(name)); |
| + return adoptRefWillBeNoop(new DOMError(name)); |
| } |
| - static PassRefPtr<DOMError> create(const String& name, const String& message) |
| + static PassRefPtrWillBeRawPtr<DOMError> create(const String& name, const String& message) |
| { |
| - return adoptRef(new DOMError(name, message)); |
| + return adoptRefWillBeNoop(new DOMError(name, message)); |
| } |
| - static PassRefPtr<DOMError> create(ExceptionCode ec) |
| + static PassRefPtrWillBeRawPtr<DOMError> create(ExceptionCode ec) |
| { |
| - return adoptRef(new DOMError(DOMException::getErrorName(ec), DOMException::getErrorMessage(ec))); |
| + return adoptRefWillBeNoop(new DOMError(DOMException::getErrorName(ec), DOMException::getErrorMessage(ec))); |
| } |
| - static PassRefPtr<DOMError> create(ExceptionCode ec, const String& message) |
| + static PassRefPtrWillBeRawPtr<DOMError> create(ExceptionCode ec, const String& message) |
| { |
| - return adoptRef(new DOMError(DOMException::getErrorName(ec), message)); |
| + return adoptRefWillBeNoop(new DOMError(DOMException::getErrorName(ec), message)); |
| } |
| const String& name() const { return m_name; } |
| const String& message() const { return m_message; } |
| + void trace(Visitor*) { } |
|
haraken
2014/02/27 01:19:29
This should be virtual.
sof
2014/02/27 06:48:07
I'm not sure about that given its nature. I raised
|
| + |
| protected: |
| explicit DOMError(const String& name); |
| DOMError(const String& name, const String& message); |