Oilpan: move core/fileapi to oilpan's heap.

Source/core/fileapi/FileError.h

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef FileError_h
 #define FileError_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/dom/DOMError.h"
+#include "heap/Handle.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 class ExceptionState;
 
 class FileError : public DOMError {

[haraken, 2014/02/24 13:49:14]

Let's override a trace() method in all subclasses of a garbage-collected class
(even if the class does not have any Member).

[sof, 2014/02/24 17:09:09]

Even if the class, like here, doesn't have any other virtual methods?

[haraken, 2014/02/27 06:53:22]

IMO the answer is yes unless the class is not memory-sensitive. In other words,
if the class is memory-sensitive, we should have traceAfterDispatch(). If the
class is not memory-sensitive, we should have virtual trace().

[sof, 2014/02/27 07:16:36]

Subclassing DOMError isn't something that's commonly done, so I would
additionally preach common sense in that regard :)

i.e., FileError is legacy and something that will eventually be deprecated &
removed. It is no longer in the spec &  use counter data for it can be found
here http://www.chromestatus.com/metrics/feature/timeline/popularity/126

[haraken, 2014/02/27 07:20:12]

Makes sense, then let's go this way. Once we add a Member to FileError, we will
be asserted by Ian's plugin :)

 public:
     enum ErrorCode {
         OK = 0,
         NOT_FOUND_ERR = 1,
         SECURITY_ERR = 2,
         ABORT_ERR = 3,
         NOT_READABLE_ERR = 4,
         ENCODING_ERR = 5,
         NO_MODIFICATION_ALLOWED_ERR = 6,
         INVALID_STATE_ERR = 7,
         SYNTAX_ERR = 8,
         INVALID_MODIFICATION_ERR = 9,
         QUOTA_EXCEEDED_ERR = 10,
         TYPE_MISMATCH_ERR = 11,
         PATH_EXISTS_ERR = 12,
     };
 
     static const char abortErrorMessage[];
     static const char encodingErrorMessage[];
     static const char invalidStateErrorMessage[];
     static const char noModificationAllowedErrorMessage[];
     static const char notFoundErrorMessage[];
     static const char notReadableErrorMessage[];
     static const char pathExistsErrorMessage[];
     static const char quotaExceededErrorMessage[];
     static const char securityErrorMessage[];
     static const char syntaxErrorMessage[];
     static const char typeMismatchErrorMessage[];
 
-    static PassRefPtr<FileError> create(ErrorCode code) { return adoptRef(new FileError(code)); }
+    static PassRefPtrWillBeRawPtr<FileError> create(ErrorCode code)
+    {
+        return adoptRefWillBeNoop(new FileError(code));
+    }
 
     ErrorCode code() const { return m_code; }
 
     static void throwDOMException(ExceptionState&, ErrorCode);
 
 private:
     explicit FileError(ErrorCode);
 
     ErrorCode m_code;
 };
 
 } // namespace WebCore
 
 #endif // FileError_h