Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1768493002: Fix SubtreeLayoutScope not to schedule relayout (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix SubtreeLayoutScope not to schedule relayout This patch fixes SubtreeLayoutScope::setNeedsLayout() and setChildNeedsLayout() not to schedule relayout when they call markContainerChainForLayout(). The signature of markContainerChainForLayout() allows to schedule relayout even when SubtreeLayoutScope exists. To not allow scheduling relayout while we're in layout, this patch changes the signature. BUG=590620 Review URL: https://codereview.chromium.org/1755543002 Cr-Commit-Position: refs/heads/master@{#378639} (cherry picked from commit 6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1) Committed: https://chromium.googlesource.com/chromium/src/+/1fb49bb47cbcb17f44198fc2a906928adf4dbaff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/layout/subtree-layout-percent-height-assert.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/layout/subtree-layout-percent-height-assert-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 9 months ago (2016-03-04 05:19:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fb49bb47cbcb17f44198fc2a906928adf4dbaff.

Powered by Google App Engine
This is Rietveld 408576698