Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 1755543002: Fix SubtreeLayoutScope not to schedule relayout (Closed)

Created:
3 years, 5 months ago by kojii
Modified:
3 years, 5 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SubtreeLayoutScope not to schedule relayout This patch fixes SubtreeLayoutScope::setNeedsLayout() and setChildNeedsLayout() not to schedule relayout when they call markContainerChainForLayout(). The signature of markContainerChainForLayout() allows to schedule relayout even when SubtreeLayoutScope exists. To not allow scheduling relayout while we're in layout, this patch changes the signature. BUG=590620 Committed: https://crrev.com/6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1 Cr-Commit-Position: refs/heads/master@{#378639}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/layout/subtree-layout-percent-height-assert.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/layout/subtree-layout-percent-height-assert-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kojii
PTAL. Thank you for the advice on the bug, I hope I understand this correctly. ...
3 years, 5 months ago (2016-03-01 15:51:42 UTC) #3
leviw_travelin_and_unemployed
cbiesinger ran into this issue as well.
3 years, 5 months ago (2016-03-01 23:54:43 UTC) #5
leviw_travelin_and_unemployed
I think this is perfect! LGTM!
3 years, 5 months ago (2016-03-01 23:56:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755543002/20001
3 years, 5 months ago (2016-03-02 00:57:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 5 months ago (2016-03-02 01:05:04 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1 Cr-Commit-Position: refs/heads/master@{#378639}
3 years, 5 months ago (2016-03-02 01:06:14 UTC) #11
cbiesinger
3 years, 5 months ago (2016-03-02 01:40:00 UTC) #12
Message was sent while issue was closed.
Thanks! Much better than what I'd have done.

Powered by Google App Engine
This is Rietveld 408576698