Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1768483002: FrameSelection::selectAll() should not call selectionFromContentsOfNode() with detached node (Closed)

Created:
4 years, 9 months ago by Xiaocheng
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameSelection::selectAll() should not call selectionFromContentsOfNode() with detached node BUG=591001 Committed: https://crrev.com/f52d88ac2c0e7814a7af9250f7cb89d6134794ae Cr-Commit-Position: refs/heads/master@{#379247}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Xiaocheng
PTAL.
4 years, 9 months ago (2016-03-04 05:39:55 UTC) #2
yosin_UTC9
https://codereview.chromium.org/1768483002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/1768483002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode865 third_party/WebKit/Source/core/editing/FrameSelection.cpp:865: if (!root->inDocument()) One more thing, we should check |root| ...
4 years, 9 months ago (2016-03-04 06:06:48 UTC) #3
Xiaocheng
Revised accordingly. PTAL at patch 2. https://codereview.chromium.org/1768483002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/1768483002/diff/1/third_party/WebKit/Source/core/editing/FrameSelection.cpp#newcode865 third_party/WebKit/Source/core/editing/FrameSelection.cpp:865: if (!root->inDocument()) On ...
4 years, 9 months ago (2016-03-04 06:30:35 UTC) #4
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-04 06:36:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768483002/20001
4 years, 9 months ago (2016-03-04 06:36:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 08:25:20 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 08:26:14 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f52d88ac2c0e7814a7af9250f7cb89d6134794ae
Cr-Commit-Position: refs/heads/master@{#379247}

Powered by Google App Engine
This is Rietveld 408576698