Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 1768483002: FrameSelection::selectAll() should not call selectionFromContentsOfNode() with detached node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 22fe9fbd89ee7dfd71d6c9b437dac1f27085536b..ea53a274dc77431adeca7186a1d67e0e64253aca 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -858,8 +858,13 @@ void FrameSelection::selectAll()
if (!root || editingIgnoresContent(root.get()))
return;
- if (selectStartTarget && selectStartTarget->dispatchEvent(Event::createCancelableBubble(EventTypeNames::selectstart)) != DispatchEventResult::NotCanceled)
- return;
+ if (selectStartTarget) {
+ if (selectStartTarget->dispatchEvent(Event::createCancelableBubble(EventTypeNames::selectstart)) != DispatchEventResult::NotCanceled)
+ return;
+ // |root| may be detached due to selectstart event.
+ if (!root->inDocument() || root->document() != document)
+ return;
+ }
VisibleSelection newSelection(VisibleSelection::selectionFromContentsOfNode(root.get()));
setSelection(newSelection);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698