[wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

[wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

I implemented I64ShrU and I64ShrS the same as I64Shl in https://codereview.chromium.org/1756863002

R=titzer@chromium.org

Committed: https://crrev.com/240b7db9c78685c603278bb1ac136b35de37b8c3
Cr-Commit-Position: refs/heads/master@{#34630}

[titzer, 2016-03-07 19:25:35]

https://codereview.chromium.org/1768233002/diff/20001/src/ia32/macro-assemble...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/1768233002/diff/20001/src/ia32/macro-assemble...
src/ia32/macro-assembler-ia32.cc:731: void MacroAssembler::PairShr(Register dst,
Register src, uint8_t shift) {
{dst} and {src} are misnamed. They should be {hi} and {lo}, and they are
modified in place.

https://codereview.chromium.org/1768233002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/int64-lowering-unittest.cc (right):

https://codereview.chromium.org/1768233002/diff/20001/test/unittests/compiler...
test/unittests/compiler/int64-lowering-unittest.cc:378: if (4 != kPointerSize)
return;
Sorry I didn't notice this before. You shouldn't check the pointer size, but you
should make a MachineOperatorBuilder with the appropriate word size. Similarly
in in64-lowering; you should check the word size of the MachineOperatorBuilder.

[ahaas, 2016-03-08 07:58:42]

https://codereview.chromium.org/1768233002/diff/20001/src/ia32/macro-assemble...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/1768233002/diff/20001/src/ia32/macro-assemble...
src/ia32/macro-assembler-ia32.cc:731: void MacroAssembler::PairShr(Register dst,
Register src, uint8_t shift) {
On 2016/03/07 at 19:25:35, titzer wrote:
> {dst} and {src} are misnamed. They should be {hi} and {lo}, and they are
modified in place.

Done.

https://codereview.chromium.org/1768233002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/int64-lowering-unittest.cc (right):

https://codereview.chromium.org/1768233002/diff/20001/test/unittests/compiler...
test/unittests/compiler/int64-lowering-unittest.cc:378: if (4 != kPointerSize)
return;
On 2016/03/07 at 19:25:35, titzer wrote:
> Sorry I didn't notice this before. You shouldn't check the pointer size, but
you should make a MachineOperatorBuilder with the appropriate word size.
Similarly in in64-lowering; you should check the word size of the
MachineOperatorBuilder.

I created a separate CL(https://codereview.chromium.org/1770333002) for this.

[titzer, 2016-03-09 09:31:44]

LGTM other than naming suggestion.

https://codereview.chromium.org/1768233002/diff/80001/src/ia32/macro-assemble...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/1768233002/diff/80001/src/ia32/macro-assemble...
src/ia32/macro-assembler-ia32.cc:709: void MacroAssembler::PairShl(Register
high, Register low, uint8_t shift) {
Can we rename these PairX to XPair? That's a little more consistent with the
assembler names, since they are usually addq, addl, etc, with the type at the
end.

[ahaas, 2016-03-09 16:22:32]

On 2016/03/09 at 09:31:44, titzer wrote:
> LGTM other than naming suggestion.
> 
>
https://codereview.chromium.org/1768233002/diff/80001/src/ia32/macro-assemble...
> File src/ia32/macro-assembler-ia32.cc (right):
> 
>
https://codereview.chromium.org/1768233002/diff/80001/src/ia32/macro-assemble...
> src/ia32/macro-assembler-ia32.cc:709: void MacroAssembler::PairShl(Register
high, Register low, uint8_t shift) {
> Can we rename these PairX to XPair? That's a little more consistent with the
assembler names, since they are usually addq, addl, etc, with the type at the
end.

Done.

[ahaas, 2016-03-09 16:22:47]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-09 16:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1768233002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-09 16:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768233002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768233002/120001

[commit-bot: I haz the power, 2016-03-09 16:37:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-09 16:38:49]

Description was changed from

==========
[wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

I implemented I64ShrU and I64ShrS the same as I64Shl in
https://codereview.chromium.org/1756863002

R=titzer@chromium.org
==========

to

==========
[wasm] Int64Lowering of I64ShrU and I64ShrS on ia32.

I implemented I64ShrU and I64ShrS the same as I64Shl in
https://codereview.chromium.org/1756863002

R=titzer@chromium.org

Committed: https://crrev.com/240b7db9c78685c603278bb1ac136b35de37b8c3
Cr-Commit-Position: refs/heads/master@{#34630}
==========

[commit-bot: I haz the power, 2016-03-09 16:38:50]

Patchset 7 (id:??) landed as
https://crrev.com/240b7db9c78685c603278bb1ac136b35de37b8c3
Cr-Commit-Position: refs/heads/master@{#34630}