Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1768163003: Do not check ProxyInfo if the the DRP config is not valid (Closed)

Created:
4 years, 9 months ago by tbansal1
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Do not check ProxyInfo if the the DRP config is not valid A previous CL (https://codereview.chromium.org/1702253002) made a change and called result->proxy_server() without checking if DRP config is valid. This caused Chrome to crash because if config is not valid, calling result- >proxy_server() may cause crashes (because there may not be any proxy server in result). This CL reverts back to behavior before that CL. Before result->proxy_server() is called, it is ensured that the DRP config must be valid. BUG=591356 Review URL: https://codereview.chromium.org/1756323002 Cr-Commit-Position: refs/heads/master@{#379048} (cherry picked from commit 50eb58711b04bd731486974488e46546bf45b0bb) Committed: https://chromium.googlesource.com/chromium/src/+/af925bedc19ae2c7a7a2b065baae730edc6e3143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 9 months ago (2016-03-07 23:08:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af925bedc19ae2c7a7a2b065baae730edc6e3143.

Powered by Google App Engine
This is Rietveld 408576698