Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

Issue 1768163003: Do not check ProxyInfo if the the DRP config is not valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
index 7c24d0c4acecd4b3dfdb353fb778474b9110da56..147a283d317332a3016e72c3320f26aec1478a50 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
@@ -417,9 +417,6 @@ TEST_F(DataReductionProxyDelegateTest, HTTPRequests) {
"http://www.example.com/", true, false, true,
},
{
- "http://www.example.com/", false, false, false,
- },
- {
"https://www.example.com/", false, true, false,
},
{
@@ -437,6 +434,8 @@ TEST_F(DataReductionProxyDelegateTest, HTTPRequests) {
};
for (size_t i = 0; i < arraysize(tests); ++i) {
+ ASSERT_TRUE(tests[i].use_direct_proxy || tests[i].enabled_by_user);
+ ASSERT_TRUE(tests[i].enabled_by_user || !tests[i].expect_histogram);
base::HistogramTester histogram_tester;
GURL url(tests[i].url);
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698