Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1768143003: Use specific messages for const constructor with body. (Closed)

Created:
4 years, 9 months ago by Johnni Winther
Modified:
4 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use specific messages for const constructor with body. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/b31a2566d44155bd23071cd6243a4fe2ac354504

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -70 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 2 chunks +11 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 1 4 chunks +6 lines, -22 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 1 2 chunks +4 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/generated/shared_messages.json File pkg/dart_messages/lib/generated/shared_messages.json (right): https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/generated/shared_messages.json#newcode25 pkg/dart_messages/lib/generated/shared_messages.json:25: "CONST_CONSTRUCTOR_OR_FACTORY_WITH_BODY": { What to do with this entry?
4 years, 9 months ago (2016-03-08 09:36:07 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/shared_messages.dart File pkg/dart_messages/lib/shared_messages.dart (right): https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/shared_messages.dart#newcode195 pkg/dart_messages/lib/shared_messages.dart:195: 'CONST_CONSTRUCTOR_OR_FACTORY_WITH_BODY': new Message( As long as we haven't ...
4 years, 9 months ago (2016-03-08 10:56:52 UTC) #3
Johnni Winther
https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/shared_messages.dart File pkg/dart_messages/lib/shared_messages.dart (right): https://codereview.chromium.org/1768143003/diff/1/pkg/dart_messages/lib/shared_messages.dart#newcode195 pkg/dart_messages/lib/shared_messages.dart:195: 'CONST_CONSTRUCTOR_OR_FACTORY_WITH_BODY': new Message( On 2016/03/08 10:56:52, floitsch wrote: > ...
4 years, 9 months ago (2016-03-10 08:55:42 UTC) #4
Johnni Winther
4 years, 9 months ago (2016-03-10 09:09:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b31a2566d44155bd23071cd6243a4fe2ac354504 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698