Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 1768143003: Use specific messages for const constructor with body. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * The messages in this file should meet the following guide lines: 7 * The messages in this file should meet the following guide lines:
8 * 8 *
9 * 1. The message should be a complete sentence starting with an uppercase 9 * 1. The message should be a complete sentence starting with an uppercase
10 * letter, and ending with a period. 10 * letter, and ending with a period.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 UNDEFINED_STATIC_SETTER_BUT_GETTER, 137 UNDEFINED_STATIC_SETTER_BUT_GETTER,
138 CANNOT_RESOLVE_TYPE, 138 CANNOT_RESOLVE_TYPE,
139 RETURN_IN_GENERATIVE_CONSTRUCTOR, 139 RETURN_IN_GENERATIVE_CONSTRUCTOR,
140 CLASS_NAME_EXPECTED, 140 CLASS_NAME_EXPECTED,
141 COMPILER_CRASHED, 141 COMPILER_CRASHED,
142 COMPLEX_RETURNING_NSM, 142 COMPLEX_RETURNING_NSM,
143 COMPLEX_THROWING_NSM, 143 COMPLEX_THROWING_NSM,
144 CONSIDER_ANALYZE_ALL, 144 CONSIDER_ANALYZE_ALL,
145 CONST_CALLS_NON_CONST, 145 CONST_CALLS_NON_CONST,
146 CONST_CALLS_NON_CONST_FOR_IMPLICIT, 146 CONST_CALLS_NON_CONST_FOR_IMPLICIT,
147 CONST_CONSTRUCTOR_OR_FACTORY_WITH_BODY, 147 CONST_CONSTRUCTOR_WITH_BODY,
148 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS, 148 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS,
149 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS_CONSTRUCTOR, 149 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS_CONSTRUCTOR,
150 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS_FIELD, 150 CONST_CONSTRUCTOR_WITH_NONFINAL_FIELDS_FIELD,
151 CONST_FACTORY,
151 CONST_LOOP_VARIABLE, 152 CONST_LOOP_VARIABLE,
152 CONST_MAP_KEY_OVERRIDES_EQUALS, 153 CONST_MAP_KEY_OVERRIDES_EQUALS,
153 CONST_WITHOUT_INITIALIZER, 154 CONST_WITHOUT_INITIALIZER,
154 CONSTRUCTOR_CALL_EXPECTED, 155 CONSTRUCTOR_CALL_EXPECTED,
155 CONSTRUCTOR_IS_NOT_CONST, 156 CONSTRUCTOR_IS_NOT_CONST,
156 CONSTRUCTOR_WITH_RETURN_TYPE, 157 CONSTRUCTOR_WITH_RETURN_TYPE,
157 CYCLIC_CLASS_HIERARCHY, 158 CYCLIC_CLASS_HIERARCHY,
158 CYCLIC_COMPILE_TIME_CONSTANTS, 159 CYCLIC_COMPILE_TIME_CONSTANTS,
159 CYCLIC_REDIRECTING_FACTORY, 160 CYCLIC_REDIRECTING_FACTORY,
160 CYCLIC_TYPE_VARIABLE, 161 CYCLIC_TYPE_VARIABLE,
(...skipping 3462 matching lines...) Expand 10 before | Expand all | Expand 10 after
3623 static String convertToString(value) { 3624 static String convertToString(value) {
3624 if (value is ErrorToken) { 3625 if (value is ErrorToken) {
3625 // Shouldn't happen. 3626 // Shouldn't happen.
3626 return value.assertionMessage; 3627 return value.assertionMessage;
3627 } else if (value is Token) { 3628 } else if (value is Token) {
3628 value = value.value; 3629 value = value.value;
3629 } 3630 }
3630 return '$value'; 3631 return '$value';
3631 } 3632 }
3632 } 3633 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart ('k') | pkg/compiler/lib/src/parser/member_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698