Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on.

ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
index 179d88ef3a587020ae572bfa1d637eb6b79d4d39..acc98f6d9227d8e34f87a963507cec4241cdb0a4 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
@@ -115,8 +115,12 @@ NaClSubprocess* PnaclTranslateThread::StartSubprocess(
   PLUGIN_PRINTF(("PnaclTranslateThread::StartSubprocess (url_for_nexe=%s)\n",
                  url_for_nexe.c_str()));
   nacl::DescWrapper* wrapper = resources_->WrapperForUrl(url_for_nexe);
+  // Supply a fake URL for the translator components so that NaCl GDB

[teravest, 2014/02/25 18:51:29]

How is the url fake?

[jvoung (off chromium), 2014/02/25 23:52:31]

Perhaps taking the word "fake" out will be less confusing.

What I was thinking is that you can usually type a URL into the omnibar (even if
it was chrome://), and there would be handler. For these components, the only
handler is the pnacl_resources code along with "WrapperForUrl". Otherwise, it's
just a string for displaying on the task manager and for filtering in this CL.

+  // can filter processes (and not debug the translator itself if desired).
+  // Must have the full URL otherwise it gets silently dropped.
+  nacl::string full_url = resources_->GetFullUrl(url_for_nexe);
   nacl::scoped_ptr<NaClSubprocess> subprocess(
-      plugin_->LoadHelperNaClModule(wrapper, manifest, error_info));
+      plugin_->LoadHelperNaClModule(full_url, wrapper, manifest, error_info));
   if (subprocess.get() == NULL) {
     PLUGIN_PRINTF((
         "PnaclTranslateThread::StartSubprocess: subprocess creation failed\n"));