Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on.

ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h"
 
 #include <iterator>
 
 #include "native_client/src/trusted/desc/nacl_desc_wrapper.h"
 #include "ppapi/native_client/src/trusted/plugin/plugin.h"
@@ skipping 97 matching lines @@
   bytes->resize(buffer_size);
 }
 
 NaClSubprocess* PnaclTranslateThread::StartSubprocess(
     const nacl::string& url_for_nexe,
     const Manifest* manifest,
     ErrorInfo* error_info) {
   PLUGIN_PRINTF(("PnaclTranslateThread::StartSubprocess (url_for_nexe=%s)\n",
                  url_for_nexe.c_str()));
   nacl::DescWrapper* wrapper = resources_->WrapperForUrl(url_for_nexe);
+  // Supply a fake URL for the translator components so that NaCl GDB

[teravest, 2014/02/25 18:51:29]

How is the url fake?

[jvoung (off chromium), 2014/02/25 23:52:31]

Perhaps taking the word "fake" out will be less confusing.

What I was thinking is that you can usually type a URL into the omnibar (even if
it was chrome://), and there would be handler. For these components, the only
handler is the pnacl_resources code along with "WrapperForUrl". Otherwise, it's
just a string for displaying on the task manager and for filtering in this CL.

+  // can filter processes (and not debug the translator itself if desired).
+  // Must have the full URL otherwise it gets silently dropped.
+  nacl::string full_url = resources_->GetFullUrl(url_for_nexe);
   nacl::scoped_ptr<NaClSubprocess> subprocess(
-      plugin_->LoadHelperNaClModule(wrapper, manifest, error_info));
+      plugin_->LoadHelperNaClModule(full_url, wrapper, manifest, error_info));
   if (subprocess.get() == NULL) {
     PLUGIN_PRINTF((
         "PnaclTranslateThread::StartSubprocess: subprocess creation failed\n"));
     return NULL;
   }
   return subprocess.release();
 }
 
 void WINAPI PnaclTranslateThread::DoTranslateThread(void* arg) {
   PnaclTranslateThread* translator =
@@ skipping 323 matching lines @@
   AbortSubprocesses();
   if (translate_thread_ != NULL)
     NaClThreadJoin(translate_thread_.get());
   PLUGIN_PRINTF(("~PnaclTranslateThread joined\n"));
   NaClCondVarDtor(&buffer_cond_);
   NaClMutexDtor(&cond_mu_);
   NaClMutexDtor(&subprocess_mu_);
 }
 
 } // namespace plugin