Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 176813010: Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: explain more Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_process_host.cc
diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc
index eae244b46c386212b76cbfae106e5aa38bbad23a..db3c1918b5854f0fbdb4f25c8e71b10f29bdcf8c 100644
--- a/components/nacl/browser/nacl_process_host.cc
+++ b/components/nacl/browser/nacl_process_host.cc
@@ -341,8 +341,14 @@ void NaClProcessHost::EarlyStartup() {
UMA_HISTOGRAM_BOOLEAN(
"NaCl.enable-nacl-debug",
cmd->HasSwitch(switches::kEnableNaClDebug));
- NaClBrowser::GetDelegate()->SetDebugPatterns(
- cmd->GetSwitchValueASCII(switches::kNaClDebugMask));
+ std::string nacl_debug_mask =
+ cmd->GetSwitchValueASCII(switches::kNaClDebugMask);
+ // By default, exclude debugging SSH and the PNaCl translator.
+ // about::flags only allows empty flags as the default, so replace
+ // the empty setting with the default. To debug all apps, use a wild-card.
+ if (nacl_debug_mask.empty())
+ nacl_debug_mask = "!*://*/*ssh_client.nmf,chrome://pnacl-translator/*";
bradn 2014/03/06 18:56:34 { } goto fail :-) ?
jvoung (off chromium) 2014/03/06 19:02:51 Done.
+ NaClBrowser::GetDelegate()->SetDebugPatterns(nacl_debug_mask);
}
void NaClProcessHost::Launch(

Powered by Google App Engine
This is Rietveld 408576698