Avoid blocking the PNaCl translator processes when chrome NaCl GDB flag is on.

components/nacl/browser/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/browser/nacl_process_host.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 323 matching lines @@
   CommandLine* cmd = CommandLine::ForCurrentProcess();
   UMA_HISTOGRAM_BOOLEAN(
       "NaCl.nacl-gdb",
       !cmd->GetSwitchValuePath(switches::kNaClGdb).empty());
   UMA_HISTOGRAM_BOOLEAN(
       "NaCl.nacl-gdb-script",
       !cmd->GetSwitchValuePath(switches::kNaClGdbScript).empty());
   UMA_HISTOGRAM_BOOLEAN(
       "NaCl.enable-nacl-debug",
       cmd->HasSwitch(switches::kEnableNaClDebug));
-  NaClBrowser::GetDelegate()->SetDebugPatterns(
-      cmd->GetSwitchValueASCII(switches::kNaClDebugMask));
+  std::string nacl_debug_mask =
+      cmd->GetSwitchValueASCII(switches::kNaClDebugMask);
+  // By default, exclude debugging SSH and the PNaCl translator.
+  // about::flags only allows empty flags as the default, so replace
+  // the empty setting with the default. To debug all apps, use a wild-card.
+  if (nacl_debug_mask.empty())
+    nacl_debug_mask = "!*://*/*ssh_client.nmf,chrome://pnacl-translator/*";

[bradn, 2014/03/06 18:56:34]

{
}
goto fail :-) ?

[jvoung (off chromium), 2014/03/06 19:02:51]

Done.

+  NaClBrowser::GetDelegate()->SetDebugPatterns(nacl_debug_mask);
 }
 
 void NaClProcessHost::Launch(
     NaClHostMessageFilter* nacl_host_message_filter,
     IPC::Message* reply_msg,
     const base::FilePath& manifest_path) {
   nacl_host_message_filter_ = nacl_host_message_filter;
   reply_msg_ = reply_msg;
   manifest_path_ = manifest_path;
 
@@ skipping 690 matching lines @@
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif
 
 }  // namespace nacl