Use scoped_ptr instead of linked_ptr from /e/c/features/*

Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/a7670dbc0a6b94e2c1c427f6a1ddae933bdb6f53
Cr-Commit-Position: refs/heads/master@{#379547}

[limasdf, 2016-03-07 11:45:14]

Patchset #1 (id:1) has been deleted

[limasdf, 2016-03-07 11:46:34]

Description was changed from

==========
Use scoped_ptr instead of linked_ptr from /e/c/feature/*

BUG=
==========

to

==========
Use scoped_ptr instead of linked_ptr from /e/c/feature/*

BUG=556939
==========

[limasdf, 2016-03-07 11:46:34]

limasdf@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[limasdf, 2016-03-07 11:47:32]

Description was changed from

==========
Use scoped_ptr instead of linked_ptr from /e/c/feature/*

BUG=556939
==========

to

==========
Use scoped_ptr instead of linked_ptr from /e/c/feature/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

[limasdf, 2016-03-07 11:50:06]

Description was changed from

==========
Use scoped_ptr instead of linked_ptr from /e/c/feature/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

[limasdf, 2016-03-07 12:22:32]

TBRing... it's mechanical cleanup.

[limasdf, 2016-03-07 12:22:37]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-03-07 12:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1768103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1768103002/20001

[commit-bot: I haz the power, 2016-03-07 13:24:46]

Description was changed from

==========
Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

[commit-bot: I haz the power, 2016-03-07 13:24:47]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-03-07 13:26:23]

Description was changed from

==========
Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Use scoped_ptr instead of linked_ptr from /e/c/features/*

BUG=556939
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/a7670dbc0a6b94e2c1c427f6a1ddae933bdb6f53
Cr-Commit-Position: refs/heads/master@{#379547}
==========

[commit-bot: I haz the power, 2016-03-07 13:26:24]

Patchset 1 (id:??) landed as
https://crrev.com/a7670dbc0a6b94e2c1c427f6a1ddae933bdb6f53
Cr-Commit-Position: refs/heads/master@{#379547}

[Devlin, 2016-03-07 15:49:43]

retroactive lgtm with one nit.

Also, please don't TBR changes without anyone reviewing them.  TBRing mechanical
changes is fine once someone else has looked at the code, but any patch should
have at least two pairs of eyes (you and one reviewer) see it before it lands.
:)

https://codereview.chromium.org/1768103002/diff/20001/extensions/common/featu...
File extensions/common/features/base_feature_provider.cc (right):

https://codereview.chromium.org/1768103002/diff/20001/extensions/common/featu...
extensions/common/features/base_feature_provider.cc:189: const auto first_child
= features_.lower_bound(prefix);
This conversion to auto is potentially harmful, because auto doesn't always know
if it's an iterator or a const_iterator.  We might be okay in this particular
case because the const on the method might require a const_iterator here, but
that's pretty flimsy (and if this was operating on a ptr member, it wouldn't
work).  I'd prefer these to stay explicitly const_iterators.

[limasdf, 2016-03-07 23:56:38]

On 2016/03/07 15:49:43, Devlin wrote:
> retroactive lgtm with one nit.
> 
> Also, please don't TBR changes without anyone reviewing them.  TBRing
mechanical
> changes is fine once someone else has looked at the code, but any patch should
> have at least two pairs of eyes (you and one reviewer) see it before it lands.
> :)
> 
>
https://codereview.chromium.org/1768103002/diff/20001/extensions/common/featu...
> File extensions/common/features/base_feature_provider.cc (right):
> 
>
https://codereview.chromium.org/1768103002/diff/20001/extensions/common/featu...
> extensions/common/features/base_feature_provider.cc:189: const auto
first_child
> = features_.lower_bound(prefix);
> This conversion to auto is potentially harmful, because auto doesn't always
know
> if it's an iterator or a const_iterator.  We might be okay in this particular
> case because the const on the method might require a const_iterator here, but
> that's pretty flimsy (and if this was operating on a ptr member, it wouldn't
> work).  I'd prefer these to stay explicitly const_iterators.

Thanks for the review.

Above comment will be addressed in https://codereview.chromium.org/1772683002/