Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: extensions/common/features/base_feature_provider.h

Issue 1768103002: Use scoped_ptr instead of linked_ptr from /e/c/features/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 5 #ifndef EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
6 #define EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 6 #define EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/memory/linked_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/values.h"
14 #include "extensions/common/features/feature_provider.h" 13 #include "extensions/common/features/feature_provider.h"
15 #include "extensions/common/features/simple_feature.h" 14 #include "extensions/common/features/simple_feature.h"
16 15
16 namespace Base {
17 class DictionaryValue;
18 }
19
17 namespace extensions { 20 namespace extensions {
18 21
19 // Reads Features out of a simple JSON file description. 22 // Reads Features out of a simple JSON file description.
20 class BaseFeatureProvider : public FeatureProvider { 23 class BaseFeatureProvider : public FeatureProvider {
21 public: 24 public:
22 typedef SimpleFeature*(*FeatureFactory)(); 25 typedef SimpleFeature*(*FeatureFactory)();
23 26
24 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the 27 // Creates a new BaseFeatureProvider. Pass null to |factory| to have the
25 // provider create plain old Feature instances. 28 // provider create plain old Feature instances.
26 BaseFeatureProvider(const base::DictionaryValue& root, 29 BaseFeatureProvider(const base::DictionaryValue& root,
27 FeatureFactory factory); 30 FeatureFactory factory);
28 ~BaseFeatureProvider() override; 31 ~BaseFeatureProvider() override;
29 32
30 // Gets the feature |feature_name|, if it exists. 33 // Gets the feature |feature_name|, if it exists.
31 Feature* GetFeature(const std::string& feature_name) const override; 34 Feature* GetFeature(const std::string& feature_name) const override;
32 Feature* GetParent(Feature* feature) const override; 35 Feature* GetParent(Feature* feature) const override;
33 std::vector<Feature*> GetChildren(const Feature& parent) const override; 36 std::vector<Feature*> GetChildren(const Feature& parent) const override;
34 37
35 const std::vector<std::string>& GetAllFeatureNames() const override; 38 const std::vector<std::string>& GetAllFeatureNames() const override;
36 39
37 private: 40 private:
38 typedef std::map<std::string, linked_ptr<Feature> > FeatureMap; 41 std::map<std::string, scoped_ptr<Feature>> features_;
39 FeatureMap features_;
40 42
41 // Populated on first use. 43 // Populated on first use.
42 mutable std::vector<std::string> feature_names_; 44 mutable std::vector<std::string> feature_names_;
43 45
44 FeatureFactory factory_; 46 FeatureFactory factory_;
45 }; 47 };
46 48
47 } // namespace extensions 49 } // namespace extensions
48 50
49 #endif // EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_ 51 #endif // EXTENSIONS_COMMON_FEATURES_BASE_FEATURE_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698