Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1767973002: Closure: convert md_history to v2 GYP (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, arv+watch_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: convert md_history to v2 GYP R=tsergeant@chromium.org BUG=585553 Committed: https://crrev.com/8ac9c40b9f65ccccd9ff8206565c3c916b395ebd Cr-Commit-Position: refs/heads/master@{#379720}

Patch Set 1 : constants.html #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -64 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_history/compiled_resources2.gyp View 1 1 chunk +20 lines, -32 lines 0 comments Download
A chrome/browser/resources/md_history/constants.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/md_history/constants.js View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history.js View 1 6 chunks +20 lines, -23 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1775803002 Patch 60001

Messages

Total messages: 13 (5 generated)
Dan Beam
totallly air coded, will try soon (you're welcome to patch as well)
4 years, 9 months ago (2016-03-06 02:36:49 UTC) #1
Dan Beam
On 2016/03/06 02:36:49, Dan Beam wrote: > totallly air coded, will try soon (you're welcome ...
4 years, 9 months ago (2016-03-07 02:21:01 UTC) #2
tsergeant
Cool, generally looks good, although a patch landed earlier today which conflicts with this. Incidentally, ...
4 years, 9 months ago (2016-03-07 04:06:33 UTC) #3
Dan Beam
merged
4 years, 9 months ago (2016-03-07 22:40:49 UTC) #4
tsergeant
lgtm
4 years, 9 months ago (2016-03-08 01:38:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767973002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767973002/80001
4 years, 9 months ago (2016-03-08 01:45:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 9 months ago (2016-03-08 03:42:40 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 03:43:48 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ac9c40b9f65ccccd9ff8206565c3c916b395ebd
Cr-Commit-Position: refs/heads/master@{#379720}

Powered by Google App Engine
This is Rietveld 408576698