MD Settings: add a semi-functional System page

MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
Committed: https://crrev.com/d16965f44f689e8a7863ab3fbfd9773836067bd6
Cr-Commit-Position: refs/heads/master@{#380059}

[Dan Beam, 2016-03-08 06:36:36]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-03-08 06:40:05]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-03-08 07:11:37]

Patchset #1 (id:40001) has been deleted

[Dan Beam, 2016-03-08 07:13:03]

Description was changed from

==========
MD Settings: add a semi-functional System page

Still need to take an action when "Change proxy settings" is tapped

R=dpapad@chromium.org,stevenjb@chromium.org
BUG=546844
==========

to

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardward acceleration to take effect
* write tests

R=stevenjb@chromium.org
BUG=546844
==========

[Dan Beam, 2016-03-08 07:13:03]

dbeam@chromium.org changed reviewers:
- dpapad@chromium.org

[Dan Beam, 2016-03-08 07:13:11]

Description was changed from

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardward acceleration to take effect
* write tests

R=stevenjb@chromium.org
BUG=546844
==========

to

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardward acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

[Dan Beam, 2016-03-08 07:13:21]

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/settings_private/prefs_util.cc (right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/settings_private/prefs_util.cc:569:
g_browser_process->local_state()->FindPreference(pref_name);
i guess this is the first local_state() pref we've ever try to set ...

[stevenjb, 2016-03-08 23:13:31]

lgtm w/ nits

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/system_page/system_page.js (right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/system_page/system_page.js:4: 
While the @fileoverview comments are mostly rote, I think it's better to have
them for consistency. In some places they are helpful, and in this case I think
it would be nice to add a brief description of what 'System' refers to (e.g.
'settings related to the operating system').

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/system_page/system_page_delegate.js
(right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/system_page/system_page_delegate.js:4: 
nit: @fileoverview for newcomers to the code.

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:949:
IDS_SETTINGS_SYSTEM_BACKGROUND_APPS_LABEL);
Exclude on osx?

[Dan Beam, 2016-03-09 02:31:31]

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/system_page/system_page.js (right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/system_page/system_page.js:4: 
On 2016/03/08 23:13:31, stevenjb wrote:
> While the @fileoverview comments are mostly rote, I think it's better to have
> them for consistency. In some places they are helpful, and in this case I
think
> it would be nice to add a brief description of what 'System' refers to (e.g.
> 'settings related to the operating system').

Done.

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/system_page/system_page_delegate.js
(right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/system_page/system_page_delegate.js:4: 
On 2016/03/08 23:13:31, stevenjb wrote:
> nit: @fileoverview for newcomers to the code.

Done.

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1775803002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:949:
IDS_SETTINGS_SYSTEM_BACKGROUND_APPS_LABEL);
On 2016/03/08 23:13:31, stevenjb wrote:
> Exclude on osx?

Done.

[Dan Beam, 2016-03-09 02:31:47]

Description was changed from

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardward acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

to

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

[Dan Beam, 2016-03-09 03:23:37]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-03-09 03:23:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1775803002/#ps80001
(title: "stevenjb@ review")

[commit-bot: I haz the power, 2016-03-09 03:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1775803002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1775803002/80001

[commit-bot: I haz the power, 2016-03-09 04:00:32]

Description was changed from

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

to

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

[commit-bot: I haz the power, 2016-03-09 04:00:34]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-09 04:01:47]

Description was changed from

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844
==========

to

==========
MD Settings: add a semi-functional System page

Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?

R=stevenjb@chromium.org
BUG=546844

Committed: https://crrev.com/d16965f44f689e8a7863ab3fbfd9773836067bd6
Cr-Commit-Position: refs/heads/master@{#380059}
==========

[commit-bot: I haz the power, 2016-03-09 04:01:48]

Patchset 2 (id:??) landed as
https://crrev.com/d16965f44f689e8a7863ab3fbfd9773836067bd6
Cr-Commit-Position: refs/heads/master@{#380059}