third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

index 741d3bb65209ea1f948d229855f814bb71ddf82c..7b915917db76dc5ea36ad980e3487cb6d40c917e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h

@@ -34,7 +34,7 @@ public:

virtual ~V8RuntimeAgent() { }

// Embedder notification API.

- virtual void reportExecutionContextCreated(v8::Local<v8::Context>, const String& type, const String& origin, const String& humanReadableName, const String& frameId) = 0;

+ virtual void reportExecutionContextCreated(v8::Local<v8::Context>, const String16& type, const String16& origin, const String16& humanReadableName, const String16& frameId) = 0;

virtual void reportExecutionContextDestroyed(v8::Local<v8::Context>) = 0;

// Embedder API.

@@ -44,11 +44,11 @@ public:

virtual void setInspectObjectCallback(PassOwnPtr<InspectCallback>) = 0;

// FIXME: remove while preserving the default context evaluation.

virtual int ensureDefaultContextAvailable(v8::Local<v8::Context>) = 0;

- virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String& groupName, bool generatePreview = false) = 0;

+ virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) = 0;

// FIXME: remove when console.table moves into V8 inspector.

virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) = 0;

- virtual v8::Local<v8::Value> findObject(const String& objectId, v8::Local<v8::Context>* = nullptr, String* objectGroup = nullptr) = 0;

- virtual void disposeObjectGroup(const String&) = 0;

+ virtual v8::Local<v8::Value> findObject(const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;

+ virtual void disposeObjectGroup(const String16&) = 0;

virtual void addInspectedObject(PassOwnPtr<Inspectable>) = 0;

virtual void clearInspectedObjects() = 0;

};