third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

index 5cbd871f45c85d1ffbc4828a3903e9e8f480db6a..f14214486ba0fca00175c64f86726905a7275adf 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

@@ -28,7 +28,7 @@ public:

virtual v8::MaybeLocal<v8::Value> callFunction(v8::Local<v8::Function>, v8::Local<v8::Context>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;

virtual v8::MaybeLocal<v8::Value> callInternalFunction(v8::Local<v8::Function>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;

- virtual String valueSubtype(v8::Local<v8::Value>) = 0;

+ virtual String16 valueSubtype(v8::Local<v8::Value>) = 0;

virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;

virtual bool hasRecursionLevel() = 0;

virtual double currentTimeMS() = 0;