third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

index 03274ad89beb85cfb05577d5b8f0af42024cb5a8..d6fff842763be797264032c9cdf573d1e3b27ba3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

@@ -38,7 +38,7 @@

namespace blink {

-V8FunctionCall::V8FunctionCall(V8DebuggerClient* client, v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String& name)

+V8FunctionCall::V8FunctionCall(V8DebuggerClient* client, v8::Local<v8::Context> context, v8::Local<v8::Value> value, const String16& name)

: m_client(client)

, m_context(context)

, m_name(toV8String(context->GetIsolate(), name))

@@ -51,7 +51,7 @@ void V8FunctionCall::appendArgument(v8::Local<v8::Value> value)

m_arguments.append(value);

}

-void V8FunctionCall::appendArgument(const String& argument)

+void V8FunctionCall::appendArgument(const String16& argument)

{

m_arguments.append(toV8String(m_context->GetIsolate(), argument));

}