third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h b/third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h

index 48bdc6faaf2c3a1acf529fde5f4aba4fb7772dc5..6b2db214985c85046b792c9e05592ec9bae67f50 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h

@@ -31,14 +31,14 @@

#define ScriptBreakpoint_h

#include "platform/inspector_protocol/Allocator.h"

-#include "wtf/text/WTFString.h"

+#include "platform/inspector_protocol/String16.h"

namespace blink {

struct ScriptBreakpoint {

- ScriptBreakpoint() : ScriptBreakpoint(0, 0, String()) { }

+ ScriptBreakpoint() : ScriptBreakpoint(0, 0, String16()) { }

- ScriptBreakpoint(int lineNumber, int columnNumber, const String& condition)

+ ScriptBreakpoint(int lineNumber, int columnNumber, const String16& condition)

: lineNumber(lineNumber)

, columnNumber(columnNumber)

, condition(condition)

@@ -47,7 +47,7 @@ struct ScriptBreakpoint {

int lineNumber;

int columnNumber;

- String condition;

+ String16 condition;

};

} // namespace blink