third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

index a53a8bc0b59bf3533f6dba41c02665f15fcd8380..e5bf86a7ddf793ea81fb7d207efc6493f9606c1b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

@@ -90,7 +90,7 @@ function concat(array1, array2)

function toString(obj)

{

- // We don't use String(obj) because String could be overridden.

+ // We don't use String(obj) because String16 could be overridden.

// Also the ("" + obj) expression may throw.

try {

return "" + obj;