Source/core/loader/DocumentLoader.cpp - Issue 176763009: Have DOMWindow deal with references instead of pointers when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentLoader.cpp

Issue 176763009: Have DOMWindow deal with references instead of pointers when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/DocumentLoader.cpp

diff --git a/Source/core/loader/DocumentLoader.cpp b/Source/core/loader/DocumentLoader.cpp

index 4c2f53a150ae65b4282d22cd8b48ba45415ea68a..5dc38f6e0a9a9a5e1d33f6a206e9fcb088892fb8 100644

--- a/Source/core/loader/DocumentLoader.cpp

+++ b/Source/core/loader/DocumentLoader.cpp

@@ -314,7 +314,7 @@ bool DocumentLoader::shouldContinueForNavigationPolicy(const ResourceRequest& re

return true;

if (policy == NavigationPolicyIgnore)

return false;

- if (!DOMWindow::allowPopUp(m_frame) && !UserGestureIndicator::processingUserGesture())

+ if (!DOMWindow::allowPopUp(*m_frame) && !UserGestureIndicator::processingUserGesture())

return false;

frameLoader()->client()->loadURLExternally(request, policy);

return false;

@@ -809,7 +809,7 @@ PassRefPtr<DocumentWriter> DocumentLoader::createWriterFor(LocalFrame* frame, co

frame->document()->prepareForDestruction();

if (!shouldReuseDefaultView)

- frame->setDOMWindow(DOMWindow::create(frame));

+ frame->setDOMWindow(DOMWindow::create(*frame));

RefPtr<Document> document = frame->domWindow()->installNewDocument(mimeType, init);

if (ownerDocument) {

« no previous file with comments | « Source/core/html/HTMLFormElement.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »