Source/core/html/HTMLFormElement.cpp - Issue 176763009: Have DOMWindow deal with references instead of pointers when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 176763009: Have DOMWindow deal with references instead of pointers when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFormElement.cpp

diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp

index 714faf234c8f7edd64389a32e0fee3d35e547965..132049010ae4a70ccdff304ec3cb43f1995647fa 100644

--- a/Source/core/html/HTMLFormElement.cpp

+++ b/Source/core/html/HTMLFormElement.cpp

@@ -423,7 +423,7 @@ void HTMLFormElement::scheduleFormSubmission(PassRefPtr<FormSubmission> submissi

LocalFrame* targetFrame = document().frame()->loader().findFrameForNavigation(submission->target(), submission->state()->sourceDocument());

if (!targetFrame) {

- if (!DOMWindow::allowPopUp(document().frame()) && !UserGestureIndicator::processingUserGesture())

+ if (!DOMWindow::allowPopUp(*document().frame()) && !UserGestureIndicator::processingUserGesture())

return;

targetFrame = document().frame();

} else {

« no previous file with comments | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »