Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3693)

Unified Diff: chrome/browser/ui/views/infobars/infobar_container_view.cc

Issue 1767363002: [md] Give each infobar its own layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_container_view.cc
diff --git a/chrome/browser/ui/views/infobars/infobar_container_view.cc b/chrome/browser/ui/views/infobars/infobar_container_view.cc
index 450d69f52c0eafff5892eb3d168fe1627f06021c..cc3f0f3a644789e6c464891495137ed4002fe29c 100644
--- a/chrome/browser/ui/views/infobars/infobar_container_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_container_view.cc
@@ -18,8 +18,6 @@ InfoBarContainerView::InfoBarContainerView(Delegate* delegate)
: infobars::InfoBarContainer(delegate) {
set_id(VIEW_ID_INFO_BAR_CONTAINER);
SetEventTargeter(make_scoped_ptr(new views::ViewTargeter(this)));
- SetPaintToLayer(true);
- layer()->SetFillsBoundsOpaquely(false);
}
InfoBarContainerView::~InfoBarContainerView() {
@@ -73,5 +71,5 @@ bool InfoBarContainerView::DoesIntersectRect(const View* target,
DCHECK_EQ(this, target);
// Don't handle events on the vertical overlap portion of the view (the
// vertical space occupied by the arrow).
Peter Kasting 2016/03/08 01:08:17 Add to this comment to describe why we want to rej
Evan Stade 2016/03/08 01:43:29 Done.
- return rect.bottom() >= GetVerticalOverlap(nullptr);
+ return rect.CenterPoint().y() >= GetVerticalOverlap(nullptr);
Peter Kasting 2016/03/08 01:08:17 Why did this have to be changed? I'm getting incr
Evan Stade 2016/03/08 01:43:29 It did not have to be part of this CL. It's somewh
tdanderson 2016/03/14 17:53:03 You should leave this as rect.bottom() (explained
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/infobars/infobar_view.h » ('j') | chrome/browser/ui/views/infobars/infobar_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698