[md] Give each infobar its own layer.

chrome/browser/ui/views/infobars/infobar_container_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"
 
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/infobars/infobar_view.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/view_targeter.h"
 
 // static
 const char InfoBarContainerView::kViewClassName[] = "InfoBarContainerView";
 
 InfoBarContainerView::InfoBarContainerView(Delegate* delegate)
     : infobars::InfoBarContainer(delegate) {
   set_id(VIEW_ID_INFO_BAR_CONTAINER);
   SetEventTargeter(make_scoped_ptr(new views::ViewTargeter(this)));
-  SetPaintToLayer(true);
-  layer()->SetFillsBoundsOpaquely(false);
 }
 
 InfoBarContainerView::~InfoBarContainerView() {
   RemoveAllInfoBarsForDestruction();
 }
 
 gfx::Size InfoBarContainerView::GetPreferredSize() const {
   int total_height;
   GetVerticalOverlap(&total_height);
   gfx::Size size(0, total_height);
@@ skipping 28 matching lines @@
     size_t position) {
   AddChildViewAt(static_cast<InfoBarView*>(infobar),
                  static_cast<int>(position));
 }
 
 void InfoBarContainerView::PlatformSpecificRemoveInfoBar(
     infobars::InfoBar* infobar) {
   RemoveChildView(static_cast<InfoBarView*>(infobar));
 }
 
 bool InfoBarContainerView::DoesIntersectRect(const View* target,

[Evan Stade, 2016/03/08 00:54:04]

it seems it's necessary to keep this as well as adding DoesIntersectRect to the
individual bars

                                              const gfx::Rect& rect) const {
   DCHECK_EQ(this, target);
   // Don't handle events on the vertical overlap portion of the view (the
   // vertical space occupied by the arrow).

[Peter Kasting, 2016/03/08 01:08:17]

Add to this comment to describe why we want to reject these.

[Evan Stade, 2016/03/08 01:43:29]

Done.

-  return rect.bottom() >= GetVerticalOverlap(nullptr);
+  return rect.CenterPoint().y() >= GetVerticalOverlap(nullptr);

[Peter Kasting, 2016/03/08 01:08:17]

Why did this have to be changed?

I'm getting increasingly uncomfortable with this inequality -- can we just do a
true intersection of the non-top-arrow part of the container view with the
supplied rect?

[Evan Stade, 2016/03/08 01:43:29]

It did not have to be part of this CL. It's somewhat tangential.

When you're using a mouse, it won't make a difference, which is why it seemed
right to me before. Now that I think more about it, it seems wrong because if
you are considering touch events, we probably want to check the middle of your
finger, not the bottom edge.

[tdanderson, 2016/03/14 17:53:03]

You should leave this as rect.bottom() (explained in my other comment).

 }