Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2381)

Unified Diff: ash/launcher/launcher_view_unittest.cc

Issue 17673004: Insert panel icons on the left of other panel icons. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix test assertions. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/launcher/launcher_view_unittest.cc
diff --git a/ash/launcher/launcher_view_unittest.cc b/ash/launcher/launcher_view_unittest.cc
index 6ca05b0df574b1dba311eb4649354b248b5319cd..989c584db248284053df8e7b5acde7cc13c7a52c 100644
--- a/ash/launcher/launcher_view_unittest.cc
+++ b/ash/launcher/launcher_view_unittest.cc
@@ -535,20 +535,20 @@ TEST_F(LauncherViewTest, BrowserHidesExcessPanels) {
}
// The first panel should now be hidden by the new browsers needing space.
- EXPECT_FALSE(GetButtonByID(first_panel)->visible());
- EXPECT_TRUE(GetButtonByID(last_panel)->visible());
+ EXPECT_TRUE(GetButtonByID(first_panel)->visible());
+ EXPECT_FALSE(GetButtonByID(last_panel)->visible());
EXPECT_TRUE(GetButtonByID(browser)->visible());
// Adding browsers should eventually begin to hide browsers. We will add
// browsers until either the last panel or browser is hidden.
items_added = 0;
while (GetButtonByID(browser)->visible() &&
- GetButtonByID(last_panel)->visible()) {
+ GetButtonByID(first_panel)->visible()) {
browser = AddTabbedBrowser();
++items_added;
ASSERT_LT(items_added, 10000);
}
- EXPECT_TRUE(GetButtonByID(last_panel)->visible());
+ EXPECT_TRUE(GetButtonByID(first_panel)->visible());
EXPECT_FALSE(GetButtonByID(browser)->visible());
}

Powered by Google App Engine
This is Rietveld 408576698