Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/download/download_request_limiter_unittest.cc

Issue 1767083004: Add DCHECK for primary_url and secondary_url in HostContentSettingsMap::GetPatternsFromScopingType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change again... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_request_limiter_unittest.cc
diff --git a/chrome/browser/download/download_request_limiter_unittest.cc b/chrome/browser/download/download_request_limiter_unittest.cc
index 7a3bf4a6714cde2cbadcf168d7571079ef2c0d87..d9d8ed82df576b64a3ea5e6653cf025bb223967c 100644
--- a/chrome/browser/download/download_request_limiter_unittest.cc
+++ b/chrome/browser/download/download_request_limiter_unittest.cc
@@ -253,6 +253,7 @@ class DownloadRequestLimiterTest : public ChromeRenderViewHostTestHarness {
};
TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_Allow) {
+ NavigateAndCommit(GURL("http://foo.com/bar"));
LoadCompleted();
// All tabs should initially start at ALLOW_ONE_DOWNLOAD.
@@ -463,6 +464,11 @@ TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_ResetOnReload) {
TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_RawWebContents) {
scoped_ptr<WebContents> web_contents(CreateTestWebContents());
+ // To make sure that url is not empty.
dominickn 2016/03/14 04:02:44 Nit: I don't think this comment is needed.
lshang 2016/03/16 02:42:16 Done.
+ GURL url("http://foo.com/bar");
+ web_contents.get()->GetController().LoadURL(
dominickn 2016/03/14 04:02:44 Nit: I think this can just be web_contents->GetCon
lshang 2016/03/16 02:42:16 Done.
+ url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
+
// DownloadRequestLimiter won't try to make a permission bubble if there's
// no permission bubble manager, so don't put one on the test WebContents.
« no previous file with comments | « no previous file | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698