PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
R=dschuff@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/5c7c074c8f5e1d819dfa95ab34afd7a8d723ba42

[Petr Hosek, 2016-03-07 20:43:32]

phosek@chromium.org changed reviewers:
+ dschuff@chromium.org

[Derek Schuff, 2016-03-07 21:26:18]

change looks fine but it looks like SJLJ EH isn't quite right?

https://codereview.chromium.org/1767083003/diff/1/pnacl/driver/pnacl-ld.py
File pnacl/driver/pnacl-ld.py (right):

https://codereview.chromium.org/1767083003/diff/1/pnacl/driver/pnacl-ld.py#ne...
pnacl/driver/pnacl-ld.py:56: '-plugin-opt=no-finalize',
So the default is to simplify+finalize, and this disables that, so it can be
done explicitly by pnacl-ld, and leads to the same behavior as before?

[Petr Hosek, 2016-03-07 23:29:26]

Description was changed from

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl

This pulls in the following LLVM changes:

0a4fdf8: (mseaborn@chromium.org) PNaCl: ExpandTls: Update comment about use of
x86-style TLS layout
c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

to

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin

This pulls in the following LLVM changes:

0a4fdf8: (mseaborn@chromium.org) PNaCl: ExpandTls: Update comment about use of
x86-style TLS layout
c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

[Petr Hosek, 2016-03-07 23:29:43]

https://codereview.chromium.org/1767083003/diff/1/pnacl/driver/pnacl-ld.py
File pnacl/driver/pnacl-ld.py (right):

https://codereview.chromium.org/1767083003/diff/1/pnacl/driver/pnacl-ld.py#ne...
pnacl/driver/pnacl-ld.py:56: '-plugin-opt=no-finalize',
On 2016/03/07 21:26:18, Derek Schuff wrote:
> So the default is to simplify+finalize, and this disables that, so it can be
> done explicitly by pnacl-ld, and leads to the same behavior as before?

Yes, exactly.

[Petr Hosek, 2016-03-08 00:35:28]

Patchset #2 (id:20001) has been deleted

[Petr Hosek, 2016-03-08 18:17:51]

Description was changed from

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin

This pulls in the following LLVM changes:

0a4fdf8: (mseaborn@chromium.org) PNaCl: ExpandTls: Update comment about use of
x86-style TLS layout
c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

to

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

0a4fdf8: (mseaborn@chromium.org) PNaCl: ExpandTls: Update comment about use of
x86-style TLS layout
c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

[Petr Hosek, 2016-03-08 18:20:08]

Description was changed from

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

0a4fdf8: (mseaborn@chromium.org) PNaCl: ExpandTls: Update comment about use of
x86-style TLS layout
c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

to

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

[Petr Hosek, 2016-03-08 18:20:42]

Description was changed from

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

to

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

[Petr Hosek, 2016-03-08 18:32:06]

Patchset #3 (id:60001) has been deleted

[Petr Hosek, 2016-03-08 18:32:10]

Patchset #2 (id:40001) has been deleted

[Derek Schuff, 2016-03-08 21:24:15]

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
File pnacl/driver/pnacl-driver.py (right):

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
pnacl/driver/pnacl-driver.py:76: '${IS_CXX ? -fexceptions}',
This should be overridable using -fno-exceptions.
So maybe another env var like FRONTEND_EXCEPTIONS which defaults to true, but
can be overriden if the user passes -fno-exceptions.

[Petr Hosek, 2016-03-08 21:33:22]

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
File pnacl/driver/pnacl-driver.py (right):

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
pnacl/driver/pnacl-driver.py:76: '${IS_CXX ? -fexceptions}',
On 2016/03/08 21:24:15, Derek Schuff wrote:
> This should be overridable using -fno-exceptions.
> So maybe another env var like FRONTEND_EXCEPTIONS which defaults to true, but
> can be overriden if the user passes -fno-exceptions.

We capture all '-f.*' flags and append them to CC_FLAGS, so passing in
-fno-exceptions overrides the -fexceptions (the last one wins).

[Derek Schuff, 2016-03-08 21:34:51]

lgtm

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
File pnacl/driver/pnacl-driver.py (right):

https://codereview.chromium.org/1767083003/diff/80001/pnacl/driver/pnacl-driv...
pnacl/driver/pnacl-driver.py:76: '${IS_CXX ? -fexceptions}',
On 2016/03/08 21:33:22, Petr Hosek wrote:
> On 2016/03/08 21:24:15, Derek Schuff wrote:
> > This should be overridable using -fno-exceptions.
> > So maybe another env var like FRONTEND_EXCEPTIONS which defaults to true,
but
> > can be overriden if the user passes -fno-exceptions.
> 
> We capture all '-f.*' flags and append them to CC_FLAGS, so passing in
> -fno-exceptions overrides the -fexceptions (the last one wins).

Ah yeah, i forgot about that. Do we have a test for -fexceptions? Seems like we
maybe should since pnacl's exception story is unusual. If not we should maybe
add that, but doesn't need to be in this CL.

[Petr Hosek, 2016-03-08 21:42:26]

It seems like callingconv_case_by_case does check the -fno-exceptions case, but
we could another test explicitly checking the difference between -fexceptions
and -fno-exceptions.

[Petr Hosek, 2016-03-08 22:14:39]

Description was changed from

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
==========

to

==========
PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following Clang change:

ec03bad: (phosek@chromium.org) Clang toolchain driver for PNaCl
a2e4b29: (phosek@chromium.org) Support different file extensions for LLVM gold
plugin
6836bf5: (phosek@chromium.org) Allow overriding -fno-gnu-inline-assembly

This pulls in the following LLVM changes:

c4c384b: (phosek@chromium.org) Perform bitcode simplification at link time

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347
TEST= PNaCl toolchain trybots
R=dschuff@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/5c7c074c8...
==========

[Petr Hosek, 2016-03-08 22:14:41]

Committed patchset #2 (id:80001) manually as
5c7c074c8f5e1d819dfa95ab34afd7a8d723ba42 (presubmit successful).