Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: pnacl/driver/pnacl-driver.py

Issue 1767083003: PNaCl: Update clang and llvm revision in pnacl/COMPONENT_REVISIONS (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Explicitly enable exceptions for the legacy driver Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/COMPONENT_REVISIONS ('k') | pnacl/driver/pnacl-ld.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/driver/pnacl-driver.py
diff --git a/pnacl/driver/pnacl-driver.py b/pnacl/driver/pnacl-driver.py
index 6e49517fd2d039f2c2ea2bf50ffb81ce486fa686..e72af1e757e0c008ff869e6b67908e95bc93f58f 100755
--- a/pnacl/driver/pnacl-driver.py
+++ b/pnacl/driver/pnacl-driver.py
@@ -72,7 +72,8 @@ EXTRA_ENV = {
'-fno-common ${PTHREAD ? -pthread} ' +
'-nostdinc ${BIAS_%BIAS%} ' +
'-fno-gnu-inline-asm ' +
- '-target ${FRONTEND_TRIPLE}',
+ '-target ${FRONTEND_TRIPLE} ' +
+ '${IS_CXX ? -fexceptions}',
Derek Schuff 2016/03/08 21:24:15 This should be overridable using -fno-exceptions.
Petr Hosek 2016/03/08 21:33:22 We capture all '-f.*' flags and append them to CC_
Derek Schuff 2016/03/08 21:34:51 Ah yeah, i forgot about that. Do we have a test fo
'ISYSTEM' : '${ISYSTEM_USER} ${STDINC ? ${ISYSTEM_BUILTIN}}',
« no previous file with comments | « pnacl/COMPONENT_REVISIONS ('k') | pnacl/driver/pnacl-ld.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698