Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1767083002:
No need for resolverChanged from xml parser. (Closed)
DescriptionNo need for resolverChanged from xml parser.
StyleEngine::resolverChanged now updates the list of active stylesheets.
At some point resolverChanged caused a synchronous style recalc and
layout tree update. There are indications that XSL transforms also were
hooked into that code based on the comments. XSL transforms are
triggered on XSL PI source loaded or DOM content loaded event. For CSS
stylesheets resolverChanged should be called from the StyleEngine when
sheets finishes loading etc like we do for HTML documents.
Committed: https://crrev.com/ca8cffaeb465375831002d81eca301b420917d7e
Cr-Commit-Position: refs/heads/master@{#383933}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 29 (12 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767083002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Figure out what breaks in XML. I don't know how much needs to be nuked in StyleEngine when XML finish parsing. Remove resolverChanged() calls to find out what breaks. ========== to ========== No need for resolverChanged from xml parser. StyleEngine::resolverChanged now updates the list of active stylesheets. At some point resolverChanged caused a synchronous style recalc and layout tree update. There are indications that XSL transforms also were hooked into that code based on the comments. XSL transforms are triggered on XSL PI source loaded or DOM content loaded event. For CSS stylesheets resolverChanged should be called from the StyleEngine when sheets finishes loading etc like we do for HTML documents. ==========
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767083002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + dcheng@chromium.org, tkent@chromium.org
ptal I don't know if any of you would be the best to review xml changes.
tkent@ knows more about this than I do so I defer to him.
tkent@chromium.org changed reviewers: + tasak@chromium.org
I'm not familiar with this code. tasak@, can you review this?
rune@opera.com changed reviewers: + tasak@google.com - tasak@chromium.org
@tasak: ptal?
ping
tasak@ not responding. any ideas who else could take a look at this?
tasak@google.com changed reviewers: + kouhei@chromium.org
I'm sorry. I'm not familiar with XML parser. On 2016/03/30 01:32:47, tasak wrote: So I added kouhei. I think, he knows XML parser.
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767083002/20001
On 2016/03/30 08:02:25, kouhei wrote: > lgtm thx!
Message was sent while issue was closed.
Description was changed from ========== No need for resolverChanged from xml parser. StyleEngine::resolverChanged now updates the list of active stylesheets. At some point resolverChanged caused a synchronous style recalc and layout tree update. There are indications that XSL transforms also were hooked into that code based on the comments. XSL transforms are triggered on XSL PI source loaded or DOM content loaded event. For CSS stylesheets resolverChanged should be called from the StyleEngine when sheets finishes loading etc like we do for HTML documents. ========== to ========== No need for resolverChanged from xml parser. StyleEngine::resolverChanged now updates the list of active stylesheets. At some point resolverChanged caused a synchronous style recalc and layout tree update. There are indications that XSL transforms also were hooked into that code based on the comments. XSL transforms are triggered on XSL PI source loaded or DOM content loaded event. For CSS stylesheets resolverChanged should be called from the StyleEngine when sheets finishes loading etc like we do for HTML documents. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== No need for resolverChanged from xml parser. StyleEngine::resolverChanged now updates the list of active stylesheets. At some point resolverChanged caused a synchronous style recalc and layout tree update. There are indications that XSL transforms also were hooked into that code based on the comments. XSL transforms are triggered on XSL PI source loaded or DOM content loaded event. For CSS stylesheets resolverChanged should be called from the StyleEngine when sheets finishes loading etc like we do for HTML documents. ========== to ========== No need for resolverChanged from xml parser. StyleEngine::resolverChanged now updates the list of active stylesheets. At some point resolverChanged caused a synchronous style recalc and layout tree update. There are indications that XSL transforms also were hooked into that code based on the comments. XSL transforms are triggered on XSL PI source loaded or DOM content loaded event. For CSS stylesheets resolverChanged should be called from the StyleEngine when sheets finishes loading etc like we do for HTML documents. Committed: https://crrev.com/ca8cffaeb465375831002d81eca301b420917d7e Cr-Commit-Position: refs/heads/master@{#383933} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ca8cffaeb465375831002d81eca301b420917d7e Cr-Commit-Position: refs/heads/master@{#383933} |
