Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 1767083002: No need for resolverChanged from xml parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
index 40ef1fcd118a8015b7f67b60e428f334877ee56b..7703bda709b6684c05a2d5079b9c29a0e8021046 100644
--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -443,14 +443,10 @@ void XMLDocumentParser::end()
if (m_parserPaused)
return;
- if (m_sawError) {
+ if (m_sawError)
insertErrorMessageBlock();
- } else {
+ else
updateLeafTextNode();
- // Do not bail out if in a stopped state, but notify document that
- // parsing has finished.
- document()->styleEngine().resolverChanged(FullStyleUpdate);
- }
if (isParsing())
prepareToStopParsing();
@@ -1536,16 +1532,6 @@ void XMLDocumentParser::doEnd()
} else if (m_sawXSLTransform) {
xmlDocPtr doc = xmlDocPtrForString(document(), m_originalSourceForTransform.toString(), document()->url().getString());
document()->setTransformSource(adoptPtr(new TransformSource(doc)));
- // Make the document think it's done, so it will apply XSL stylesheets.
- document()->setParsingState(Document::FinishedParsing);
- document()->styleEngine().resolverChanged(FullStyleUpdate);
-
- // resolverChanged() call can detach the parser and null out its
- // document. In that case, we just bail out.
- if (isDetached())
- return;
-
- document()->setParsingState(Document::Parsing);
DocumentParser::stopParsing();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698