Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1767063003: Add a GIF test file to test loop count behavior (Closed)

Created:
4 years, 9 months ago by urvang
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GIF test file to test loop count behavior This file has a loop count of 2, which can be verified by running: "identify -verbose full2loop.gif | grep 'Iterations'" This test file will be used in a unit test in the next patch. BUG=592735 R=noel@chromium.org, pkasting@chromium.org Committed: https://crrev.com/77ed91ec5600ab1331c2faafc1c245a2d33b28a5 Cr-Commit-Position: refs/heads/master@{#380505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/images/resources/full2loop.gif View Binary file 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
urvang
4 years, 9 months ago (2016-03-08 00:06:32 UTC) #2
Noel Gordon
LGTM.
4 years, 9 months ago (2016-03-08 12:04:19 UTC) #3
Peter Kasting
Sounds like we should probably close this.
4 years, 9 months ago (2016-03-10 09:48:01 UTC) #5
urvang
On 2016/03/10 09:48:01, Peter Kasting wrote: > Sounds like we should probably close this. Peter, ...
4 years, 9 months ago (2016-03-10 16:43:31 UTC) #6
Peter Kasting
LGTM
4 years, 9 months ago (2016-03-10 23:55:46 UTC) #9
Noel Gordon
BUG=? Please remember to fill in the bug number on submit.
4 years, 9 months ago (2016-03-11 00:31:35 UTC) #10
urvang
On 2016/03/11 00:31:35, noel gordon wrote: > BUG=? > > Please remember to fill in ...
4 years, 9 months ago (2016-03-11 01:09:50 UTC) #12
Noel Gordon
Agree, and LGTM.
4 years, 9 months ago (2016-03-11 01:21:11 UTC) #13
urvang
Committed patchset #1 (id:1) manually as 77ed91ec5600ab1331c2faafc1c245a2d33b28a5 (presubmit successful).
4 years, 9 months ago (2016-03-11 01:25:26 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 01:25:28 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77ed91ec5600ab1331c2faafc1c245a2d33b28a5
Cr-Commit-Position: refs/heads/master@{#380505}

Powered by Google App Engine
This is Rietveld 408576698