Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1769343002: GIF decoding: Add a unit test for repetition count (Closed)

Created:
4 years, 9 months ago by urvang
Modified:
4 years, 9 months ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, kinuko+watch, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_file
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GIF decoding: Add a unit test for repetition count Also add a test to BitmapImageTest to ensure we loop one extra time when animating. BUG=592735 Committed: https://crrev.com/a45163dc68252ce3f1958ab58b06a765e652eb70 Cr-Commit-Position: refs/heads/master@{#380800}

Patch Set 1 #

Patch Set 2 : Revert code change; test existing behavior instead #

Total comments: 2

Patch Set 3 : Add a test in BitmapImage to make sure we loop one extra time #

Total comments: 2

Patch Set 4 : decode all frames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (15 generated)
urvang
4 years, 9 months ago (2016-03-08 00:47:12 UTC) #2
Noel Gordon
On 2016/03/08 00:47:12, urvang wrote: > Note: I had added a note about 'repetitionCount()' method ...
4 years, 9 months ago (2016-03-08 12:17:55 UTC) #3
urvang
On 2016/03/08 12:17:55, noel gordon wrote: > On 2016/03/08 00:47:12, urvang wrote: > > > ...
4 years, 9 months ago (2016-03-08 19:08:39 UTC) #5
urvang
@Peter: Noel suggested that you would know better about this.
4 years, 9 months ago (2016-03-08 19:09:22 UTC) #7
Peter Kasting
Replied on bug. Even if we did want to change this, I don't think this ...
4 years, 9 months ago (2016-03-08 21:29:41 UTC) #8
urvang
On 2016/03/08 21:29:41, Peter Kasting wrote: > Replied on bug. Even if we did want ...
4 years, 9 months ago (2016-03-08 21:56:28 UTC) #9
Peter Kasting
Sounds like we should probably close this.
4 years, 9 months ago (2016-03-10 09:47:57 UTC) #10
urvang
On 2016/03/10 09:47:57, Peter Kasting wrote: > Sounds like we should probably close this. Changed ...
4 years, 9 months ago (2016-03-10 17:13:58 UTC) #12
Peter Kasting
Technically this just checks that we read the correct value out of the GIF, not ...
4 years, 9 months ago (2016-03-10 23:54:50 UTC) #13
Noel Gordon
https://codereview.chromium.org/1769343002/diff/20001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/1769343002/diff/20001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode516 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:516: Are there 2, or 3, frames in the test ...
4 years, 9 months ago (2016-03-11 00:39:50 UTC) #14
urvang
On 2016/03/10 23:54:50, Peter Kasting wrote: > Technically this just checks that we read the ...
4 years, 9 months ago (2016-03-11 01:05:48 UTC) #16
urvang
https://codereview.chromium.org/1769343002/diff/20001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/1769343002/diff/20001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode516 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:516: On 2016/03/11 00:39:50, noel gordon wrote: > Are there ...
4 years, 9 months ago (2016-03-11 01:13:50 UTC) #18
Noel Gordon
On 2016/03/11 01:13:50, urvang wrote: > On 2016/03/11 00:39:50, noel gordon wrote: > > Are ...
4 years, 9 months ago (2016-03-11 01:23:46 UTC) #19
Peter Kasting
LGTM (again) https://codereview.chromium.org/1769343002/diff/40001/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (right): https://codereview.chromium.org/1769343002/diff/40001/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp#newcode187 third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:187: for (int repeat = 0; repeat < ...
4 years, 9 months ago (2016-03-11 01:23:47 UTC) #20
urvang
On 2016/03/11 01:23:46, noel gordon wrote: > On 2016/03/11 01:13:50, urvang wrote: > > > ...
4 years, 9 months ago (2016-03-11 18:31:50 UTC) #23
urvang
https://codereview.chromium.org/1769343002/diff/40001/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (right): https://codereview.chromium.org/1769343002/diff/40001/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp#newcode187 third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:187: for (int repeat = 0; repeat < expectedRepetitionCount + ...
4 years, 9 months ago (2016-03-11 18:32:17 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769343002/60001
4 years, 9 months ago (2016-03-11 23:09:11 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/156390)
4 years, 9 months ago (2016-03-11 23:19:10 UTC) #29
urvang
@Ken: Need LGTM stamp for third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp Thanks!
4 years, 9 months ago (2016-03-11 23:23:37 UTC) #31
Noel Gordon
LGTM.
4 years, 9 months ago (2016-03-12 00:15:48 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769343002/60001
4 years, 9 months ago (2016-03-12 00:16:23 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-12 00:22:40 UTC) #36
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:23:44 UTC) #38
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a45163dc68252ce3f1958ab58b06a765e652eb70
Cr-Commit-Position: refs/heads/master@{#380800}

Powered by Google App Engine
This is Rietveld 408576698