Mojom parser: Compute and validate struct field ordinals.

Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order, and the
original lexical order is preserved in a field of DeclarationData called |declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so far because the
actual field ordinals are currently computed in the Python back-end using the |declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to eliminate the logic from the Python backend. Implementing the missing bits is also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=#696
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/399333c72c83f6df0bab99d1634777142b512db8

[rudominer, 2016-03-07 16:57:27]

Description was changed from

==========
Mojom parser: Implement computation and validation of struct field ordinals.

BUG=696
==========

to

==========
Mojom parser: Implement computation and validation of struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

BUG=696
==========

[rudominer, 2016-03-07 16:57:59]

Description was changed from

==========
Mojom parser: Implement computation and validation of struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

BUG=696
==========

to

==========
Mojom parser: Compute and validate of struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

BUG=696
==========

[rudominer, 2016-03-07 16:59:52]

Description was changed from

==========
Mojom parser: Compute and validate of struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

BUG=696
==========

to

==========
Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union
fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=696
==========

[rudominer, 2016-03-07 17:02:26]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-03-07 17:02:26]

Hi Alex, ptal.

[azani, 2016-03-07 19:29:45]

lgtm

[rudominer, 2016-03-07 22:13:27]

Hi Alex, I made a change to mojom_translator.py to maintain the property that
the fields of a module.Struct are sorted in lexical order, while maintaining the
value of the computed ordinal in a new attribute called |computed_ordinal|. This
new attribute is not being consumed yet.

ptal.

[azani, 2016-03-07 22:34:31]

still lgtm

[rudominer, 2016-03-07 22:42:05]

Description was changed from

==========
Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union
fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=696
==========

to

==========
Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union
fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=696
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/399333c72c83f6df0bab99d1634...
==========

[rudominer, 2016-03-07 22:42:06]

Committed patchset #3 (id:40001) manually as
399333c72c83f6df0bab99d1634777142b512db8 (presubmit successful).

[rudominer, 2016-03-18 00:12:03]

Description was changed from

==========
Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union
fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=696
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/399333c72c83f6df0bab99d1634...
==========

to

==========
Mojom parser: Compute and validate struct field ordinals.

In mojom_types.mojom struct fields are supposed to be listed in ordinal order,
and the
original lexical order is preserved in a field of DeclarationData called
|declaration_order|.

Additionally there is a field of DeclarationData called |declared_ordinal| that
records if an
explicit ordinal has been specified.

Previously only the |declared_ordinal| bit was implemented. This has worked so
far because the
actual field ordinals are currently computed in the Python back-end using the
|declared_ordinal| field.

This CL implements the missing bits which will allow us in a follow-up CL to
eliminate the logic from the Python backend. Implementing the missing bits is
also important because we are starting to re-write the backends in Go
and also because the runtime type information requires it.

This CL only deals with struct fields. There will be follow-up CLs for union
fields and other things. Note that some
ordinals are already being fully handled by the parser, namely method ordinals.

BUG=#696
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/399333c72c83f6df0bab99d1634...
==========