mojom/mojom_parser/parser/resolution_test.go - Issue 1767033002: Mojom parser: Compute and validate struct field ordinals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/parser/resolution_test.go

Issue 1767033002: Mojom parser: Compute and validate struct field ordinals. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Maintain the property that the fields of a module.Struct are sorted in declaration order. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojom/mojom_parser/parser/resolution_test.go

diff --git a/mojom/mojom_parser/parser/resolution_test.go b/mojom/mojom_parser/parser/resolution_test.go

index 789374b00bd07f87e267848df54ac836da95229a..8bd732371b3f9798875ce6f48e9fd665e3629499 100644

--- a/mojom/mojom_parser/parser/resolution_test.go

+++ b/mojom/mojom_parser/parser/resolution_test.go

@@ -1045,7 +1045,7 @@ func TestSingleFileResolutionSuccess(t *testing.T) {

testFunc := func(descriptor *mojom.MojomDescriptor) error {

myStructType := descriptor.TypesByKey["TYPE_KEY:MyStruct"].(*mojom.MojomStruct)

- aColorField := myStructType.Fields[0]

+ aColorField := myStructType.FieldsInLexicalOrder[0]

concreteValue := aColorField.DefaultValue.ResolvedConcreteValue().(*mojom.EnumValue)

key := concreteValue.ValueKey()

if key != "TYPE_KEY:Color.BLUE" {