Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1766993002: BlankText UMAs should be reported only for webfonts in block period (Closed)

Created:
4 years, 9 months ago by Kunihiko Sakamoto
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

BlankText UMAs should be reported only for webfonts in block period This fixes a bug where WebFont.HadBlankText and WebFont.BlankTextShownTime are reported incorrectly when the webfont falls back immediately, because of font-display:swap or the webfont intervention. BUG=591304 Review URL: https://codereview.chromium.org/1764913003 Cr-Commit-Position: refs/heads/master@{#379246} (cherry picked from commit 802475025dd1465c1f6f99b114d9b9ac7a37e110) Committed: https://chromium.googlesource.com/chromium/src/+/ad3c88f77d543f648f622980178fa453503d6c94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Kunihiko Sakamoto
4 years, 9 months ago (2016-03-07 03:48:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad3c88f77d543f648f622980178fa453503d6c94.

Powered by Google App Engine
This is Rietveld 408576698