Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Issue 1764913003: BlankText UMAs should be reported only for webfonts in block period (Closed)

Created:
4 years, 9 months ago by Kunihiko Sakamoto
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BlankText UMAs should be reported only for webfonts in block period This fixes a bug where WebFont.HadBlankText and WebFont.BlankTextShownTime are reported incorrectly when the webfont falls back immediately, because of font-display:swap or the webfont intervention. BUG=591304 Committed: https://crrev.com/802475025dd1465c1f6f99b114d9b9ac7a37e110 Cr-Commit-Position: refs/heads/master@{#379246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Kunihiko Sakamoto
PTAL. I'll try to merge this into M50.
4 years, 9 months ago (2016-03-04 06:23:39 UTC) #4
Takashi Toyoshima
lgtm. So, if my understandings are correct, BlankTextShownTime is not reported any more and HasBlankText ...
4 years, 9 months ago (2016-03-04 07:22:00 UTC) #5
Kunihiko Sakamoto
On 2016/03/04 07:22:00, toyoshim wrote: > lgtm. > So, if my understandings are correct, BlankTextShownTime ...
4 years, 9 months ago (2016-03-04 07:29:47 UTC) #6
kinuko
lgtm
4 years, 9 months ago (2016-03-04 08:09:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764913003/1
4 years, 9 months ago (2016-03-04 08:12:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 08:18:31 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 08:20:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/802475025dd1465c1f6f99b114d9b9ac7a37e110
Cr-Commit-Position: refs/heads/master@{#379246}

Powered by Google App Engine
This is Rietveld 408576698