Source/modules/webaudio/RealtimeAnalyser.h - Issue 176683003: HRTFDatabaseLoader is not an absolute condition to run audioContext

Unified Diff: Source/modules/webaudio/RealtimeAnalyser.h

Issue 176683003: HRTFDatabaseLoader is not an absolute condition to run audioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webaudio/PannerNode.cpp ('K') | « Source/modules/webaudio/PannerNode.cpp ('k') | Source/modules/webaudio/RealtimeAnalyser.cpp » ('j') | Source/modules/webaudio/RealtimeAnalyser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/RealtimeAnalyser.h

diff --git a/Source/modules/webaudio/RealtimeAnalyser.h b/Source/modules/webaudio/RealtimeAnalyser.h

index f599e55b6555b42f3068cd91f6f647fd2c89bb60..3a422aa2840cf370c0a3e7f0425fdd1cb35a1e7b 100644

--- a/Source/modules/webaudio/RealtimeAnalyser.h

+++ b/Source/modules/webaudio/RealtimeAnalyser.h

@@ -26,6 +26,7 @@

#define RealtimeAnalyser_h

#include "platform/audio/AudioArray.h"

+#include "platform/audio/FFTFrame.h"

Raymond Toy (Google) 2014/02/24 23:01:22 Why is this added here and the class FFTFrame del

KhNo 2014/02/25 02:00:25 There was an compilation error from removing "HRFT

There was an compilation error from removing "HRFTDatabaseLoader.h" on AudioContext.h. In file included from ../../third_party/WebKit/Source/wtf/OwnPtr.h:27:0, from ../../third_party/WebKit/Source/heap/ThreadState.h:37, from ../../third_party/WebKit/Source/heap/Heap.h:36, from ../../third_party/WebKit/Source/heap/Handle.h:34, from ../../third_party/WebKit/Source/bindings/v8/WrapperTypeInfo.h:35, from ../../third_party/WebKit/Source/bindings/v8/UnsafePersistent.h:34, from ../../third_party/WebKit/Source/bindings/v8/ScriptWrappable.h:34, from ../../third_party/WebKit/Source/modules/webaudio/AudioNode.h:28, from ../../third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h:28, from ../../third_party/WebKit/Source/modules/webaudio/AnalyserNode.h:28, from ../../third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp:29: ../../third_party/WebKit/Source/wtf/OwnPtrCommon.h: In static member function ‘static void WTF::OwnedPtrDeleter<T>::deletePtr(T*) [with T = WebCore::FFTFrame]’: ../../third_party/WebKit/Source/wtf/OwnPtr.h:62:13: instantiated from ‘WTF::OwnPtr<T>::~OwnPtr() [with T = WebCore::FFTFrame]’ ../../third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.h:38:7: instantiated from here ../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:51:1: error: invalid application of ‘sizeof’ to incomplete type ‘WebCore::FFTFrame’ ../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9: error: possible problem detected in invocation of delete operator: [-Werror] ../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:48:17: error: ‘ptr’ has incomplete type [-Werror] ../../third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.h:36:7: error: forward declaration of ‘struct WebCore::FFTFrame’ [-Werror] ../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined It needs to using 'sizeof' about FFTFrame on delete operator in RealtimeAnalyser.h Could you recommand the way to avoid this compilation error if you knows ?

#include "wtf/Forward.h"

#include "wtf/Noncopyable.h"

#include "wtf/OwnPtr.h"

@@ -33,7 +34,6 @@

namespace WebCore {

class AudioBus;

-class FFTFrame;

class RealtimeAnalyser FINAL {

WTF_MAKE_NONCOPYABLE(RealtimeAnalyser);