HRTFDatabaseLoader is not an absolute condition to run audioContext

Source/modules/webaudio/RealtimeAnalyser.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
  * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef RealtimeAnalyser_h
 #define RealtimeAnalyser_h
 
 #include "platform/audio/AudioArray.h"
+#include "platform/audio/FFTFrame.h"

[Raymond Toy (Google), 2014/02/24 23:01:22]

Why is  this added here and the class FFTFrame deleted near line 36 below?

It seems the original code was correct.

[KhNo, 2014/02/25 02:00:25]

There was an compilation error from removing "HRFTDatabaseLoader.h" on
AudioContext.h.

In file included from ../../third_party/WebKit/Source/wtf/OwnPtr.h:27:0,
                 from ../../third_party/WebKit/Source/heap/ThreadState.h:37,
                 from ../../third_party/WebKit/Source/heap/Heap.h:36,
                 from ../../third_party/WebKit/Source/heap/Handle.h:34,
                 from
../../third_party/WebKit/Source/bindings/v8/WrapperTypeInfo.h:35,
                 from
../../third_party/WebKit/Source/bindings/v8/UnsafePersistent.h:34,
                 from
../../third_party/WebKit/Source/bindings/v8/ScriptWrappable.h:34,
                 from
../../third_party/WebKit/Source/modules/webaudio/AudioNode.h:28,
                 from
../../third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h:28,
                 from
../../third_party/WebKit/Source/modules/webaudio/AnalyserNode.h:28,
                 from
../../third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp:29:
../../third_party/WebKit/Source/wtf/OwnPtrCommon.h: In static member function
‘static void WTF::OwnedPtrDeleter<T>::deletePtr(T*) [with T =
WebCore::FFTFrame]’:
../../third_party/WebKit/Source/wtf/OwnPtr.h:62:13:   instantiated from
‘WTF::OwnPtr<T>::~OwnPtr() [with T = WebCore::FFTFrame]’
../../third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.h:38:7:  
instantiated from here
../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:51:1: error: invalid
application of ‘sizeof’ to incomplete type ‘WebCore::FFTFrame’ 
../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9: error: possible problem
detected in invocation of delete operator: [-Werror]
../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:48:17: error: ‘ptr’ has
incomplete type [-Werror]
../../third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.h:36:7: error:
forward declaration of ‘struct WebCore::FFTFrame’ [-Werror]
../../third_party/WebKit/Source/wtf/OwnPtrCommon.h:52:9: note: neither the
destructor nor the class-specific operator delete will be called, even if they
are declared when the class is defined

It needs to using 'sizeof' about FFTFrame on delete operator in
RealtimeAnalyser.h

Could you recommand the way to avoid this compilation error if you knows ?

 #include "wtf/Forward.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/OwnPtr.h"
 
 namespace WebCore {
 
 class AudioBus;
-class FFTFrame;
 
 class RealtimeAnalyser FINAL {
     WTF_MAKE_NONCOPYABLE(RealtimeAnalyser);
 public:
     RealtimeAnalyser();
 
     size_t fftSize() const { return m_fftSize; }
     bool setFftSize(size_t);
 
     unsigned frequencyBinCount() const { return m_fftSize / 2; }
@@ skipping 40 matching lines @@
     double m_smoothingTimeConstant;
 
     // The range used when converting when using getByteFrequencyData().
     double m_minDecibels;
     double m_maxDecibels;
 };
 
 } // namespace WebCore
 
 #endif // RealtimeAnalyser_h